Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2694703004: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects at most 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2694703004 Cr-Commit-Position: refs/heads/master@{#451053} Committed: https://chromium.googlesource.com/chromium/src/+/1dfd572206baea1bcb468bfe7ca33ff8736dabd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -705 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-lineWidth.html View 1 chunk +47 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-lineWidth.js View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-lineWidth-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-lineWidth-intact-after-strokeRect.html View 1 chunk +33 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-lineWidth-intact-after-strokeRect-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-longlived-context.html View 1 chunk +21 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-longlived-context.js View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-longlived-context-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-measureText.html View 1 chunk +12 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-measureText-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-modify-emptyPath.html View 1 chunk +94 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-modify-emptyPath-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-overloads-drawImage.html View 1 chunk +36 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-overloads-drawImage-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-overloads-fillText.html View 1 chunk +18 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-overloads-fillText-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-overloads-strokeText.html View 1 chunk +18 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-overloads-strokeText-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-addpath.html View 1 chunk +78 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-addpath-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-constructors.html View 1 chunk +28 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-constructors-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-lineWidth-intact-after-strokeRect.js View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-modify-emptyPath.js View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImage.js View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-overloads-fillText.js View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-addpath.js View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-constructors.js View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Justin Novosad
lgtm
3 years, 10 months ago (2017-02-16 15:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694703004/1
3 years, 10 months ago (2017-02-16 18:35:23 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:37:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1dfd572206baea1bcb468bfe7ca3...

Powered by Google App Engine
This is Rietveld 408576698