Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2694643002: Remove conditional compile statements in ShareServiceImpl (and test). (Closed)

Created:
3 years, 10 months ago by Matt Giuca
Modified:
3 years, 10 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove conditional compile statements in ShareServiceImpl (and test). These were previously added to allow this code to compile (but be useless) on Mac and Android. As of r449905, these files are not compiled at all on Mac and Android, so these if statements are no longer needed. BUG=668389 Review-Url: https://codereview.chromium.org/2694643002 Cr-Commit-Position: refs/heads/master@{#450193} Committed: https://chromium.googlesource.com/chromium/src/+/f7077234f58cf96b6a9102691ce13cb28150cbab

Patch Set 1 #

Patch Set 2 : Formatting. #

Patch Set 3 : Added TODO. #

Patch Set 4 : Conditional-compile out constants not used on some platforms. #

Patch Set 5 : Rebase (constantina@'s upstream CL landed). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M chrome/browser/webshare/share_service_impl.h View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/webshare/share_service_impl.cc View 1 2 3 4 3 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/webshare/share_service_impl_unittest.cc View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (15 generated)
Matt Giuca
3 years, 10 months ago (2017-02-13 23:53:07 UTC) #9
Sam McNally
lgtm
3 years, 10 months ago (2017-02-13 23:57:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694643002/80001
3 years, 10 months ago (2017-02-13 23:58:28 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 01:46:27 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f7077234f58cf96b6a9102691ce1...

Powered by Google App Engine
This is Rietveld 408576698