Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2694623006: Enable new wpt/webvtt tests. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update expectations and baselines. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +58 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/interfaces-expected.txt View 1 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/align-expected.txt View 1 1 chunk +6 lines, -0 lines 1 comment Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/getCueAsHTML-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/line-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/snapToLines-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/text-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/vertical-expected.txt View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/entities-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tags-expected.txt View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/timestamps-expected.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tree-building-expected.txt View 1 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 10 months ago (2017-02-14 21:28:30 UTC) #3
foolip
lgtm https://codereview.chromium.org/2694623006/diff/20001/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/align-expected.txt File third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/align-expected.txt (right): https://codereview.chromium.org/2694623006/diff/20001/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/align-expected.txt#newcode3 third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/align-expected.txt:3: FAIL VTTCue.align, script-created cue assert_equals: expected "center" but ...
3 years, 10 months ago (2017-02-15 05:50:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694623006/20001
3 years, 10 months ago (2017-02-15 05:51:39 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 06:05:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8111f4d820ce77d9cfc6c1d47db3...

Powered by Google App Engine
This is Rietveld 408576698