[debugger] change coverage format to nested, with function name.

[debugger] change coverage format to nested, with function name.


R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2694623003
Cr-Commit-Position: refs/heads/master@{#43175}
Committed: https://chromium.googlesource.com/v8/v8/+/033d3b577b47a985d8720e48b725686249829c50

[Yang, 2017-02-13 09:51:49]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 09:51:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 10:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 10:15:59]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-02-13 11:39:10]

lgtm

https://codereview.chromium.org/2694623003/diff/1/src/debug/debug-coverage.cc
File src/debug/debug-coverage.cc (right):

https://codereview.chromium.org/2694623003/diff/1/src/debug/debug-coverage.cc...
src/debug/debug-coverage.cc:92: stack.push_back(&(result.back().toplevel));
Nit: Same here with parentheses.

https://codereview.chromium.org/2694623003/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2694623003/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1935: }  // anonoymous namespace
Nit: anonymous

https://codereview.chromium.org/2694623003/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1955: const auto& script = scripts[i];
Nit: The naming is getting a bit confusing now that we're also dealing with
actual scripts here. Can we call this script_data instead?

https://codereview.chromium.org/2694623003/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1961: CreateRangeObject(isolate,
&(script.toplevel), inner_string,
Nit: Don't need the parentheses around script.toplevel.

[Yang, 2017-02-14 06:26:24]

addressed comments. landing.

[Yang, 2017-02-14 06:26:28]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-14 06:26:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2694623003/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-14 06:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 06:48:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487053588493910,
"parent_rev": "0d91d379efa4dce3824d4a57f40784aa9fddf304", "commit_rev":
"033d3b577b47a985d8720e48b725686249829c50"}

[commit-bot: I haz the power, 2017-02-14 06:48:07]

Description was changed from

==========
[debugger] change coverage format to nested, with function name.


R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] change coverage format to nested, with function name.


R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2694623003
Cr-Commit-Position: refs/heads/master@{#43175}
Committed:
https://chromium.googlesource.com/v8/v8/+/033d3b577b47a985d8720e48b7256862498...
==========

[commit-bot: I haz the power, 2017-02-14 06:48:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/033d3b577b47a985d8720e48b7256862498...