Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2694623002: [intrinsics] Remove unused %_RegExpExec and %_NumberToString. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, rmcilroy, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Remove unused %_RegExpExec and %_NumberToString. These intrinsics are no longer required, but their runtime call pendants are still in use. So remove support for those from all compilers. BUG=v8:5049 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2694623002 Cr-Commit-Position: refs/heads/master@{#43131} Committed: https://chromium.googlesource.com/v8/v8/+/32ed62911f6160f5f491bd94edbcd511a5454f1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -72 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-12 18:39:48 UTC) #1
Yang
lgtm
3 years, 10 months ago (2017-02-12 19:01:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694623002/1
3 years, 10 months ago (2017-02-12 19:01:26 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-12 19:04:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/32ed62911f6160f5f491bd94edbcd511a54...

Powered by Google App Engine
This is Rietveld 408576698