Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 2694573002: Don't unconditionally create a LayoutObject for SVGMarkerElement. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by emilio
Modified:
4 months, 1 week ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't unconditionally create a LayoutObject for SVGMarkerElement. This is a followup to https://codereview.chromium.org/2685113002/. I missed this override. BUG=691196 Review-Url: https://codereview.chromium.org/2694573002 Cr-Commit-Position: refs/heads/master@{#449877} Committed: https://chromium.googlesource.com/chromium/src/+/9d35915a17f98cbdeb655d3bfac57f1432f858b4

Patch Set 1 #

Patch Set 2 : Don't unconditionally create a LayoutObject for SVGMarkerElement. #

Messages

Total messages: 10 (4 generated)
emilio
Hi fs, Mind taking a look at this trivial patch? I missed this overload in ...
4 months, 1 week ago (2017-02-11 20:01:31 UTC) #2
emilio
Forgot to check-in the test, now it's there.
4 months, 1 week ago (2017-02-11 20:09:08 UTC) #3
fs
lgtm
4 months, 1 week ago (2017-02-11 20:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694573002/20001
4 months, 1 week ago (2017-02-11 20:42:55 UTC) #6
emilio
On 2017/02/11 20:11:07, fs wrote: > lgtm Thanks for the super-fast turnaround time :)
4 months, 1 week ago (2017-02-11 20:43:07 UTC) #7
commit-bot: I haz the power
4 months, 1 week ago (2017-02-11 22:33:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d35915a17f98cbdeb655d3bfac5...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318