Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2694443002: Only show the 'Enable Mash' flag on CrOS. (Closed)

Created:
3 years, 10 months ago by mfomitchev
Modified:
3 years, 10 months ago
Reviewers:
fwang, tonikitoo, sky
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only show the 'Enable Mash' flag on CrOS. The string resources required for the 'Enable Mash' flag are only avabilable on CrOS, so only add the flag on CrOS. Note we can assume that ENABLE_PACKAGE_MASH_SERVICES is always enabled on CrOS. R=sky@chromium.org,fwang@igalia.com BUG=NONE Review-Url: https://codereview.chromium.org/2694443002 Cr-Commit-Position: refs/heads/master@{#449760} Committed: https://chromium.googlesource.com/chromium/src/+/dc04e07f3f1f4e770c09b779cad81274b8e88e79

Patch Set 1 #

Patch Set 2 : Removing accidental CL dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mfomitchev
3 years, 10 months ago (2017-02-10 19:56:56 UTC) #1
sky
LGTM
3 years, 10 months ago (2017-02-10 20:59:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694443002/20001
3 years, 10 months ago (2017-02-10 21:08:44 UTC) #7
tonikitoo
On 2017/02/10 20:59:13, sky wrote: > LGTM non-owner lgtm
3 years, 10 months ago (2017-02-10 21:09:04 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:22:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc04e07f3f1f4e770c09b779cad8...

Powered by Google App Engine
This is Rietveld 408576698