Issue 2694393003: Add missing pieces of my last CL

Issue 2694393003: Add missing pieces of my last CL (Closed)

Created:
3 years, 10 months ago by Cutch

Modified:
3 years, 10 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add missing pieces of my last CL (https://codereview.chromium.org/2695013003/) Somehow patch set #1 was landed instead of patch set #2 This CL includes the missing pieces. BUG= Committed: https://github.com/dart-lang/sdk/commit/ece78e3d5a108e32cd270faadad827fc53283e97

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -2 lines)			Patch
M	runtime/observatory/tests/service/positive_token_pos_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/regress_28443_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/service_test_common.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/set_library_debuggable_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/observatory/tests/service/step_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Cutch

Committed patchset #1 (id:1) manually as ece78e3d5a108e32cd270faadad827fc53283e97 (presubmit successful).

3 years, 10 months ago (2017-02-15 12:09:20 UTC) #2

Message was sent while issue was closed.

lgtm