Don't animate caret-color: auto

Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.
This allows us to not run animations for caret-color when one side is "auto".

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG=676295, 681424
Review-Url: https://codereview.chromium.org/2694383002
Cr-Commit-Position: refs/heads/master@{#451183}
Committed: https://chromium.googlesource.com/chromium/src/+/9a661d2c478a78a6bba5938b42f624a81a17329e

[alancutter (OOO until 2018), 2017-02-15 06:58:08]

Description was changed from

==========
Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.

BUG=676295,681424
==========

to

==========
Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG=676295,681424
==========

[alancutter (OOO until 2018), 2017-02-15 06:58:08]

alancutter@chromium.org changed reviewers:
+ rego@igalia.com

[alancutter (OOO until 2018), 2017-02-15 06:59:50]

Description was changed from

==========
Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG=676295,681424
==========

to

==========
Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.
This allows us to not run animations for caret-color when one side is "auto".

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG=676295,681424
==========

[Manuel Rego, 2017-02-15 09:23:53]

@alancutter thank you very much for working on this!

LGTM.

[alancutter (OOO until 2018), 2017-02-16 01:03:51]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 02:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:51:39]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2017-02-16 03:20:26]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-02-16 03:20:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rego@igalia.com
Link to the patchset: https://codereview.chromium.org/2694383002/#ps20001
(title: "Fix composition test")

[commit-bot: I haz the power, 2017-02-16 03:22:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:24:25]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[alancutter (OOO until 2018), 2017-02-17 00:05:45]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:07:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:19:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487289945578860,
"parent_rev": "fd39617052b8d320413f2ee20b6c1cef477336c6", "commit_rev":
"9a661d2c478a78a6bba5938b42f624a81a17329e"}

[commit-bot: I haz the power, 2017-02-17 02:20:00]

Description was changed from

==========
Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.
This allows us to not run animations for caret-color when one side is "auto".

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG=676295,681424
==========

to

==========
Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.
This allows us to not run animations for caret-color when one side is "auto".

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG=676295,681424

Review-Url: https://codereview.chromium.org/2694383002
Cr-Commit-Position: refs/heads/master@{#451183}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a661d2c478a78a6bba5938b42f6...
==========

[commit-bot: I haz the power, 2017-02-17 02:20:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a661d2c478a78a6bba5938b42f6...