Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2694363005: Add gn dependency on rtc_task_runner. (Closed)

Created:
3 years, 10 months ago by nisse-chromium (ooo August 14)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn dependency on rtc_task_runner. This is step 2 in the process of moving the task_runner abstraction from webrtc to Chrome. Step 1 was https://codereview.webrtc.org/2696703009/. BUG=webrtc:6424 TBR=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2694363005 Cr-Commit-Position: refs/heads/master@{#452001} Committed: https://chromium.googlesource.com/chromium/src/+/5767a52c001b646362585a6426a946becd1d18b1

Patch Set 1 #

Total comments: 4

Patch Set 2 : Dropped two of the rtc_task_runner deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/client/display/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/client/ios/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/ios/bridge/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle_xmpp/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
nisse-chromium (ooo August 14)
It's likely that not all of these dependencies are actually needed. But adding rtc_task_runner at ...
3 years, 10 months ago (2017-02-16 13:56:54 UTC) #2
kjellander_chromium
lgtm, thanks for figuring out the multi-step rocket and executing it!
3 years, 10 months ago (2017-02-16 14:38:45 UTC) #4
Sergey Ulanov
AFAIK jingle/notifier is the only directory in chromium that depends on task_runner, so I'm not ...
3 years, 10 months ago (2017-02-16 19:38:13 UTC) #5
nisse-chromium (ooo August 14)
Dropped two of the dependencies. I intend to purge any unneeded dependencies on rtc_task_runner still ...
3 years, 10 months ago (2017-02-20 09:51:32 UTC) #6
kjellander_chromium
Sergey: I hope you're OK with us TBRing this CL, since it's so simple. We ...
3 years, 10 months ago (2017-02-22 08:21:56 UTC) #12
kjellander_chromium
+jochen for content/ approval
3 years, 10 months ago (2017-02-22 08:24:38 UTC) #14
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-22 10:08:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694363005/20001
3 years, 10 months ago (2017-02-22 10:19:39 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 11:53:48 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5767a52c001b646362585a6426a9...

Powered by Google App Engine
This is Rietveld 408576698