Remove IsRunningOnIOS9OrLater check from elide_url_unittest

Remove IsRunningOnIOS9OrLater check from elide_url_unittest

iOS 9 is the minimum requirement.

BUG=633626
Review-Url: https://codereview.chromium.org/2694363004
Cr-Commit-Position: refs/heads/master@{#452057}
Committed: https://chromium.googlesource.com/chromium/src/+/2affa91c404bd93f81fdab4af5e6576abd64aeb2

[pkl (ping after 24h if needed), 2017-02-16 15:19:33]

pkl@chromium.org changed reviewers:
+ pkasting@chromium.org, rohitrao@chromium.org

[Peter Kasting, 2017-02-16 21:03:44]

LGTM

https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/el...
File components/url_formatter/elide_url_unittest.cc (right):

https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/el...
components/url_formatter/elide_url_unittest.cc:182: TEST(TextEliderTest,
TestHostEliding) {
It seems like this is the only test that uses NO_IOS, and it uses it on all but
the first case in its list.

I would look for a way to just remove the |platforms| member of Testcase.  The
easiest way would probably be to put "#if !defined(OS_IOS)" around all but the
first case in the list, and remove the member entirely, along with the #ifdefed
piece from the loop.

https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/el...
components/url_formatter/elide_url_unittest.cc:209: if (testcases[i].platforms
== Testcase::NO_IOS) {
Nit: No {}

[pkl (ping after 24h if needed), 2017-02-22 14:47:57]

https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/el...
File components/url_formatter/elide_url_unittest.cc (right):

https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/el...
components/url_formatter/elide_url_unittest.cc:182: TEST(TextEliderTest,
TestHostEliding) {
On 2017/02/16 21:03:43, Peter Kasting wrote:
> It seems like this is the only test that uses NO_IOS, and it uses it on all
but
> the first case in its list.
> 
> I would look for a way to just remove the |platforms| member of Testcase.  The
> easiest way would probably be to put "#if !defined(OS_IOS)" around all but the
> first case in the list, and remove the member entirely, along with the
#ifdefed
> piece from the loop.

Yes, makes a lot of sense. Thank you!

[pkl (ping after 24h if needed), 2017-02-22 14:48:05]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-02-22 14:48:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2694363004/#ps20001
(title: "simplified conditionals")

[commit-bot: I haz the power, 2017-02-22 14:48:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 15:23:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487774885497270,
"parent_rev": "59bef6e2cbf1b3058d14de15b4614a88fefc01ea", "commit_rev":
"2affa91c404bd93f81fdab4af5e6576abd64aeb2"}

[commit-bot: I haz the power, 2017-02-22 15:24:02]

Description was changed from

==========
Remove IsRunningOnIOS9OrLater check from elide_url_unittest

iOS 9 is the minimum requirement.

BUG=633626
==========

to

==========
Remove IsRunningOnIOS9OrLater check from elide_url_unittest

iOS 9 is the minimum requirement.

BUG=633626

Review-Url: https://codereview.chromium.org/2694363004
Cr-Commit-Position: refs/heads/master@{#452057}
Committed:
https://chromium.googlesource.com/chromium/src/+/2affa91c404bd93f81fdab4af5e6...
==========

[commit-bot: I haz the power, 2017-02-22 15:24:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2affa91c404bd93f81fdab4af5e6...