Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2694363004: Remove IsRunningOnIOS9OrLater check from elide_url_unittest (Closed)

Created:
3 years, 10 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IsRunningOnIOS9OrLater check from elide_url_unittest iOS 9 is the minimum requirement. BUG=633626 Review-Url: https://codereview.chromium.org/2694363004 Cr-Commit-Position: refs/heads/master@{#452057} Committed: https://chromium.googlesource.com/chromium/src/+/2affa91c404bd93f81fdab4af5e6576abd64aeb2

Patch Set 1 #

Total comments: 3

Patch Set 2 : simplified conditionals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M components/url_formatter/elide_url_unittest.cc View 1 2 chunks +20 lines, -37 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pkl (ping after 24h if needed)
3 years, 10 months ago (2017-02-16 15:19:34 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/elide_url_unittest.cc File components/url_formatter/elide_url_unittest.cc (right): https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/elide_url_unittest.cc#newcode182 components/url_formatter/elide_url_unittest.cc:182: TEST(TextEliderTest, TestHostEliding) { It seems like this is ...
3 years, 10 months ago (2017-02-16 21:03:44 UTC) #3
pkl (ping after 24h if needed)
https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/elide_url_unittest.cc File components/url_formatter/elide_url_unittest.cc (right): https://codereview.chromium.org/2694363004/diff/1/components/url_formatter/elide_url_unittest.cc#newcode182 components/url_formatter/elide_url_unittest.cc:182: TEST(TextEliderTest, TestHostEliding) { On 2017/02/16 21:03:43, Peter Kasting wrote: ...
3 years, 10 months ago (2017-02-22 14:47:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694363004/20001
3 years, 10 months ago (2017-02-22 14:48:19 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:24:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2affa91c404bd93f81fdab4af5e6...

Powered by Google App Engine
This is Rietveld 408576698