Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2694323002: media: Fix build config for audio_unittests on Android (Closed)

Created:
3 years, 10 months ago by watk
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix build config for audio_unittests on Android We were missing some deps which meant this test didn't run on Android. We didn't notice because we usually run these tests through media_unittests. BUG=691054 Review-Url: https://codereview.chromium.org/2694323002 Cr-Commit-Position: refs/heads/master@{#450517} Committed: https://chromium.googlesource.com/chromium/src/+/f7ac891577ddd5fddc4846eba0496f6d8dddab6c

Patch Set 1 #

Patch Set 2 : more commenting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M media/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
M media/base/android/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
watk
3 years, 10 months ago (2017-02-14 20:38:47 UTC) #2
watk
A reasonable question might be: why do we need these? media's run_all_unittests initializes the jni ...
3 years, 10 months ago (2017-02-14 20:41:56 UTC) #3
sandersd (OOO until July 31)
lgtm, but I'm assuming you plan to upload another PS with updated comments.
3 years, 10 months ago (2017-02-14 21:37:47 UTC) #4
watk
On 2017/02/14 21:37:47, sandersd wrote: > lgtm, but I'm assuming you plan to upload another ...
3 years, 10 months ago (2017-02-14 21:43:08 UTC) #5
sandersd (OOO until July 31)
On 2017/02/14 21:43:08, watk wrote: > On 2017/02/14 21:37:47, sandersd wrote: > > lgtm, but ...
3 years, 10 months ago (2017-02-14 21:45:38 UTC) #6
watk
On 2017/02/14 21:45:38, sandersd wrote: > On 2017/02/14 21:43:08, watk wrote: > > On 2017/02/14 ...
3 years, 10 months ago (2017-02-14 21:50:10 UTC) #7
sandersd (OOO until July 31)
lgtm
3 years, 10 months ago (2017-02-14 21:54:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694323002/20001
3 years, 10 months ago (2017-02-14 21:54:02 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:55:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7ac891577ddd5fddc4846eba049...

Powered by Google App Engine
This is Rietveld 408576698