Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2694283007: Revert of [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterface… (Closed)

Created:
3 years, 10 months ago by wychen
Modified:
3 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterface… (patchset #3 id:40001 of https://codereview.chromium.org/2684313002/ ) Reason for revert: Break SystemWebViewShellLayoutTest.SystemWebViewShellLayoutTest on WebView bots https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/2200 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20M%20%28dbg%29/builds/2200 Original issue's description: > [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterfaces. > > Implement a 'fallback' mechanism for the selection of appropriate > global interfaces file to compare with. The approach checks a number > of files in the list to determine which one to use. Due to the nature > of rebaselining in blink the suitable virtual/stable/webexposed/ > global-interface-listing-expected.txt can be located in a number of > places and can change dynamically. > > This patch also enables the testWebViewIncludedStableInterfaces test > which was previously disabled due to the above issue. > > BUG=683153, 506603, 497861 > > Review-Url: https://codereview.chromium.org/2684313002 > Cr-Commit-Position: refs/heads/master@{#450743} > Committed: https://chromium.googlesource.com/chromium/src/+/4965734c3a73e6fc608071eba416e9af6b83555d TBR=torne@chromium.org,tobiasjs@chromium.org,timvolodine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=683153, 506603, 497861 Review-Url: https://codereview.chromium.org/2694283007 Cr-Commit-Position: refs/heads/master@{#450812} Committed: https://chromium.googlesource.com/chromium/src/+/4617c896b2b96fbbb22f14c0f6626bbf4cb0aff6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M android_webview/tools/system_webview_shell/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java View 4 chunks +7 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
wychen
3 years, 10 months ago (2017-02-15 21:37:06 UTC) #2
Created Revert of [WebViewLayoutTest] Implement a fallback mechanism and
re-enable testWebViewIncludedStableInterface…

Powered by Google App Engine
This is Rietveld 408576698