Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2694273002: Revert of Refactor ContentViewClient (4/6) (Closed)

Created:
3 years, 10 months ago by amineer
Modified:
3 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, agrieve+watch_chromium.org, James Su, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor ContentViewClient (4/6) (patchset #4 id:140001 of https://codereview.chromium.org/2682593002/ ) Reason for revert: Causing major alignment issues for custom tabs BUG=691718 Original issue's description: > Refactor ContentViewClient (4/6) > > Moved following interface methods to ViewAndroid: > - onBackgroundColorChanged > - onTopControlsChanged > - onBottomControlsChanged > - onStartContentIntent > > Remove following as they are not used: > - getSystemWindowInsetTop > - getSystemWindowInsetLeft > - getSystemWindowInsetRight > > BUG=620172 > > Review-Url: https://codereview.chromium.org/2682593002 > Cr-Commit-Position: refs/heads/master@{#449186} > Committed: https://chromium.googlesource.com/chromium/src/+/d95ac3f4aad80e2102fd8cf957dc2e265c0f02f7 TBR=boliu@chromium.org,dtrainor@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620172 Review-Url: https://codereview.chromium.org/2694273002 Cr-Commit-Position: refs/heads/master@{#450616} Committed: https://chromium.googlesource.com/chromium/src/+/cefe29f6134013119b32e9e96ffa8ad3f74c5304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -383 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 3 chunks +35 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java View 5 chunks +1 line, -26 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 6 chunks +58 lines, -12 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/tab/TabViewAndroidDelegate.java View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 6 chunks +6 lines, -30 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 3 chunks +116 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 7 chunks +25 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java View 3 chunks +10 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java View 5 chunks +5 lines, -54 lines 0 comments Download
M content/public/test/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 4 chunks +28 lines, -0 lines 0 comments Download
A content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java View 1 chunk +41 lines, -0 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 4 chunks +3 lines, -7 lines 0 comments Download
D content/shell/android/java/src/org/chromium/content_shell/ShellViewAndroidDelegate.java View 1 chunk +0 lines, -52 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java View 4 chunks +0 lines, -61 lines 0 comments Download
M ui/android/view_android.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/android/view_android.cc View 3 chunks +1 line, -54 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
amineer
Created Revert of Refactor ContentViewClient (4/6)
3 years, 10 months ago (2017-02-14 18:27:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694273002/1
3 years, 10 months ago (2017-02-14 18:28:44 UTC) #3
amineer
On 2017/02/14 18:28:44, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-14 18:43:53 UTC) #5
boliu
On 2017/02/14 18:43:53, amineer wrote: > On 2017/02/14 18:28:44, commit-bot: I haz the power wrote: ...
3 years, 10 months ago (2017-02-14 18:47:17 UTC) #6
David Trainor- moved to gerrit
rubber stamp lgtm for revert.
3 years, 10 months ago (2017-02-14 19:30:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694273002/1
3 years, 10 months ago (2017-02-15 00:09:56 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 07:01:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cefe29f6134013119b32e9e96ffa...

Powered by Google App Engine
This is Rietveld 408576698