On 2017/02/14 18:28:44, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago
(2017-02-14 18:43:53 UTC)
#5
On 2017/02/14 18:28:44, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Unchecking the "commit" on this patch as the regression is not as bad as
initially feared. Given the size of the change, and the fact that this is #4 of
6 in a series, perhaps fixing would be the best course of action rather than
attempting a revert. Jinsuk, please advise.
boliu
On 2017/02/14 18:43:53, amineer wrote: > On 2017/02/14 18:28:44, commit-bot: I haz the power wrote: ...
3 years, 10 months ago
(2017-02-14 18:47:17 UTC)
#6
On 2017/02/14 18:43:53, amineer wrote:
> On 2017/02/14 18:28:44, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
>
> Unchecking the "commit" on this patch as the regression is not as bad as
> initially feared. Given the size of the change, and the fact that this is #4
of
> 6 in a series, perhaps fixing would be the best course of action rather than
> attempting a revert. Jinsuk, please advise.
just revert imo, shouldn't be very dangerous, and cq will catch and build
problems
David Trainor- moved to gerrit
rubber stamp lgtm for revert.
3 years, 10 months ago
(2017-02-14 19:30:40 UTC)
#7
rubber stamp lgtm for revert.
amineer
The CQ bit was checked by amineer@chromium.org
3 years, 10 months ago
(2017-02-15 00:08:50 UTC)
#8
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487117330666980, "parent_rev": "53d28e3d9446105d1609fba58575bc44b50127b8", "commit_rev": "cefe29f6134013119b32e9e96ffa8ad3f74c5304"}
3 years, 10 months ago
(2017-02-15 07:00:51 UTC)
#10
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487117330666980, "parent_rev":
"53d28e3d9446105d1609fba58575bc44b50127b8", "commit_rev":
"cefe29f6134013119b32e9e96ffa8ad3f74c5304"}
commit-bot: I haz the power
Description was changed from ========== Revert of Refactor ContentViewClient (4/6) (patchset #4 id:140001 of https://codereview.chromium.org/2682593002/ ...
3 years, 10 months ago
(2017-02-15 07:01:29 UTC)
#11
Issue 2694273002: Revert of Refactor ContentViewClient (4/6)
(Closed)
Created 3 years, 10 months ago by amineer
Modified 3 years, 10 months ago
Reviewers: boliu, David Trainor- moved to gerrit, Jinsuk Kim
Base URL:
Comments: 0