Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2694263004: Removed CRWSessionEntry from Tab's interface. (Closed)

Created:
3 years, 10 months ago by kkhorimoto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed CRWSessionEntry from Tab's interface. BUG=454984 Review-Url: https://codereview.chromium.org/2694263004 Cr-Commit-Position: refs/heads/master@{#450515} Committed: https://chromium.googlesource.com/chromium/src/+/0395dba8e185b1a04a81f53bec3767fb4cea2f3f

Patch Set 1 #

Patch Set 2 : remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -42 lines) Patch
M ios/chrome/browser/tabs/tab.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 12 chunks +20 lines, -35 lines 0 comments Download
M ios/chrome/browser/tabs/tab_private.h View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
kkhorimoto
3 years, 10 months ago (2017-02-14 22:32:47 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-14 22:56:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694263004/20001
3 years, 10 months ago (2017-02-14 23:08:00 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:52:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0395dba8e185b1a04a81f53bec37...

Powered by Google App Engine
This is Rietveld 408576698