|
|
Created:
3 years, 10 months ago by Gleb Lanbin Modified:
3 years, 10 months ago CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove fixed width/height for containers with orthogonal children
Code clean up:
1) Remove fixed width/height for containers with orthogonal children
2) Use raw string literals for embedded HTML
BUG=635619
Review-Url: https://codereview.chromium.org/2694263003
Cr-Commit-Position: refs/heads/master@{#450795}
Committed: https://chromium.googlesource.com/chromium/src/+/f9c746934fbb6e7205ef7ec0815957ccbc45e6b3
Patch Set 1 #Patch Set 2 : fix tests #Messages
Total messages: 20 (14 generated)
glebl@chromium.org changed reviewers: + ikilpatrick@chromium.org
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
glebl@chromium.org changed reviewers: + atotic@chromium.org
On 2017/02/14 at 19:42:44, glebl wrote: > lgtm. Removal width/height made possible by ICB fix.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm thanks, we should probably decide on a more unified form for the unit tests. I was thinking we could move everything to use setBodyHTML, and layout based on the layoutObject for an element which we wrap in a NGBlockNode. E.g. setBodyInnerHTML(...); NGBlockNode* node = new NGBlockNode( toLayoutBlockFlow(document().getElementById("container")->layoutObject())); NGConstraintSpace* space = ...; RefPtr<const NGPhysicalFragment> fragment = NGBlockLayoutAlgorithm(node, space).Layout(); thoughts?
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by glebl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org, atotic@chromium.org Link to the patchset: https://codereview.chromium.org/2694263003/#ps20001 (title: "fix tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487188172920820, "parent_rev": "1d3252cf8952ae513df5dd27ae6c57f943512d4f", "commit_rev": "f9c746934fbb6e7205ef7ec0815957ccbc45e6b3"}
Message was sent while issue was closed.
Description was changed from ========== Remove fixed width/height for containers with orthogonal children Code clean up: 1) Remove fixed width/height for containers with orthogonal children 2) Use raw string literals for embedded HTML BUG=635619 ========== to ========== Remove fixed width/height for containers with orthogonal children Code clean up: 1) Remove fixed width/height for containers with orthogonal children 2) Use raw string literals for embedded HTML BUG=635619 Review-Url: https://codereview.chromium.org/2694263003 Cr-Commit-Position: refs/heads/master@{#450795} Committed: https://chromium.googlesource.com/chromium/src/+/f9c746934fbb6e7205ef7ec08159... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f9c746934fbb6e7205ef7ec08159... |