Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.h

Issue 2694243003: Remove ThreadState::m_isAtSafePoint (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/ThreadState.h
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.h b/third_party/WebKit/Source/platform/heap/ThreadState.h
index 82c9934c2e3f2b3ed0e776c1319bdde581804633..f7091537aa57ef3e1eab05b0c588b3819aa1a74e 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.h
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.h
@@ -249,9 +249,7 @@ class PLATFORM_EXPORT ThreadState {
// Support for disallowing allocation. Mainly used for sanity
// checks asserts.
- bool isAllocationAllowed() const {
- return !isAtSafePoint() && !m_noAllocationCount;
- }
+ bool isAllocationAllowed() const { return !m_noAllocationCount; }
void enterNoAllocationScope() { m_noAllocationCount++; }
void leaveNoAllocationScope() { m_noAllocationCount--; }
bool isWrapperTracingForbidden() { return isMixinInConstruction(); }
@@ -333,7 +331,6 @@ class PLATFORM_EXPORT ThreadState {
// Mark current thread as running inside safepoint.
void enterSafePoint(BlinkGC::StackState, void*);
void leaveSafePoint();
- bool isAtSafePoint() const { return m_atSafePoint; }
void addInterruptor(std::unique_ptr<BlinkGCInterruptor>);
@@ -639,7 +636,6 @@ class PLATFORM_EXPORT ThreadState {
void* m_safePointScopeMarker;
Vector<Address> m_safePointStackCopy;
- bool m_atSafePoint;
Vector<std::unique_ptr<BlinkGCInterruptor>> m_interruptors;
bool m_sweepForbidden;
size_t m_noAllocationCount;

Powered by Google App Engine
This is Rietveld 408576698