Issue 269423003: Guard SpdyWriteQueue::Enqueue, and test all reentrancy points.

Issue 269423003: Guard SpdyWriteQueue::Enqueue, and test all reentrancy points. (Closed)

Created:
6 years, 7 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Guard SpdyWriteQueue::Enqueue, and test all reentrancy points. New tests use SpdyBuffer callbacks to enqueue additional writes, to verify that re-entrancy is allowed and that guards are not hit. Also confirmed that reverting r268730 causes these tests to fail. BUG=369539 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269246

Patch Set 1 #

Patch Set 2 : No change. Re-trying with proper base r268730. #

Total comments: 2

Patch Set 3 : requed => requeued #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -0 lines)			Patch
	M	net/spdy/spdy_write_queue.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/spdy/spdy_write_queue_unittest.cc	View	1 2	3 chunks	+124 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Good tests, thanks for writing them! LGTM https://codereview.chromium.org/269423003/diff/20001/net/spdy/spdy_write_queue_unittest.cc File net/spdy/spdy_write_queue_unittest.cc (right): https://codereview.chromium.org/269423003/diff/20001/net/spdy/spdy_write_queue_unittest.cc#newcode29 net/spdy/spdy_write_queue_unittest.cc:29: const char ...

6 years, 7 months ago (2014-05-07 21:27:47 UTC) #2

Johnny

https://codereview.chromium.org/269423003/diff/20001/net/spdy/spdy_write_queue_unittest.cc File net/spdy/spdy_write_queue_unittest.cc (right): https://codereview.chromium.org/269423003/diff/20001/net/spdy/spdy_write_queue_unittest.cc#newcode29 net/spdy/spdy_write_queue_unittest.cc:29: const char kRequed[] = "requed"; On 2014/05/07 21:27:47, willchan ...

6 years, 7 months ago (2014-05-08 02:49:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/269423003/40001

6 years, 7 months ago (2014-05-08 02:52:04 UTC) #5

Message was sent while issue was closed.

Change committed as 269246

Expand Messages | Collapse Messages