net/spdy/spdy_write_queue.cc - Issue 269423003: Guard SpdyWriteQueue::Enqueue, and test all reentrancy points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_write_queue.cc

Issue 269423003: Guard SpdyWriteQueue::Enqueue, and test all reentrancy points. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: requed => requeued Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_write_queue.cc

diff --git a/net/spdy/spdy_write_queue.cc b/net/spdy/spdy_write_queue.cc

index 44867ef8d4f51e1ee8a3c693bfae2135a54eeb51..05b965d957de13d0c3164c9177e320df6a9416ac 100644

--- a/net/spdy/spdy_write_queue.cc

+++ b/net/spdy/spdy_write_queue.cc

@@ -46,6 +46,7 @@ void SpdyWriteQueue::Enqueue(RequestPriority priority,

SpdyFrameType frame_type,

scoped_ptr<SpdyBufferProducer> frame_producer,

const base::WeakPtr<SpdyStream>& stream) {

+ CHECK(!removing_writes_);

CHECK_GE(priority, MINIMUM_PRIORITY);

CHECK_LE(priority, MAXIMUM_PRIORITY);

if (stream.get())

« no previous file with comments | « no previous file | net/spdy/spdy_write_queue_unittest.cc » ('j') | no next file with comments »