Enable SecurityTest.NewOverflow on Linux now that valgrind is gone

Enable SecurityTest.NewOverflow on Linux now that valgrind is gone

BUG=582398, 690271
Review-Url: https://codereview.chromium.org/2694173005
Cr-Commit-Position: refs/heads/master@{#451787}
Committed: https://chromium.googlesource.com/chromium/src/+/a71e1c4d8c9bb54716c7ee7f82ce6b99730bb1b7

[Nico, 2017-02-15 19:52:46]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 19:54:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-15 21:56:45]

==2949==ThreadSanitizer's allocator is terminating the process instead of
returning 0
==2949==If you don't like this behavior set allocator_may_return_null=1
FATAL: ThreadSanitizer CHECK failed:
/b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:221
"((0)) != (0)" (0x0, 0x0)
    #0 __tsan::TsanCheckFailed(char const*, int, char const*, unsigned long
long, unsigned long long) <null> (base_unittests+0x000000520b4d)
    #1 __sanitizer::CheckFailed(char const*, int, char const*, unsigned long
long, unsigned long long) <null> (base_unittests+0x0000004b5b4f)
    #2 __sanitizer::ReportAllocatorCannotReturnNull(bool) <null>
(base_unittests+0x0000004a55ff)
    #3 __tsan::user_alloc(__tsan::ThreadState*, unsigned long, unsigned long,
unsigned long, bool) <null> (base_unittests+0x0000005119fe)
    #4 operator new[](unsigned long, std::nothrow_t const&) <null>
(base_unittests+0x000000528c1b)
    #5 (anonymous namespace)::SecurityTest_NewOverflow_Test::TestBody()
base/security_unittest.cc:109:9 (base_unittests+0x0000009ddb05)
    #6 HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12 (base_unittests+0x000000f6999d)
    #7 testing::Test::Run() testing/gtest/src/gtest.cc:2474
(base_unittests+0x000000f6999d)
    #8 testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
(base_unittests+0x000000f6a5cd)
    #9 testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
(base_unittests+0x000000f6ad16)
    #10 testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4647:43 (base_unittests+0x000000f75956)
    #11 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool> testing/gtest/src/gtest.cc:2458:12 (base_unittests+0x000000f75284)
    #12 testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
(base_unittests+0x000000f75284)
    #13 RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
(base_unittests+0x000000f21789)
    #14 base::TestSuite::Run() base/test/test_suite.cc:271
(base_unittests+0x000000f21789)
    #15 Invoke<base::TestSuite *> base/bind_internal.h:214:12
(base_unittests+0x000000f101d5)
    #16 MakeItSo<int (base::TestSuite::*const &)(), base::TestSuite *>
base/bind_internal.h:285 (base_unittests+0x000000f101d5)
    #17 RunImpl<int (base::TestSuite::*const &)(), const
std::__1::tuple<base::internal::UnretainedWrapper<base::TestSuite> > &, 0>
base/bind_internal.h:361 (base_unittests+0x000000f101d5)
    #18 base::internal::Invoker<base::internal::BindState<int
(base::TestSuite::*)(), base::internal::UnretainedWrapper<base::TestSuite> >,
int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339
(base_unittests+0x000000f101d5)
    #19 Run base/callback.h:85:12 (base_unittests+0x000000f34633)
    #20 base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int
(), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int,
int, bool, base::Callback<void (), (base::internal::CopyMode)1,
(base::internal::RepeatMode)1> const&)
base/test/launcher/unit_test_launcher.cc:211 (base_unittests+0x000000f34633)
    #21 base::LaunchUnitTests(int, char**, base::Callback<int (),
(base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)
base/test/launcher/unit_test_launcher.cc:453:10 (base_unittests+0x000000f3445a)
    #22 main base/test/run_all_base_unittests.cc:22:10
(base_unittests+0x000000f10130)
    #23 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287
(libc.so.6+0x000000021f44)
    #24 _start <null> (base_unittests+0x0000004a4bcc)

on tsan

[Nico, 2017-02-15 21:59:50]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 22:01:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 22:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 22:37:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Nico, 2017-02-16 00:20:47]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 00:21:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 00:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:55:29]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-17 20:40:53]

thakis@chromium.org changed reviewers:
+ siggi@chromium.org

[Nico, 2017-02-17 20:40:53]

More follow-up to that NewOverflow change :-)

[Nico, 2017-02-17 20:44:20]

Oh, apparently I had sent this out previously to email me something. siggi,
this was a "please review", not obvious from the mail you got.

On Fri, Feb 17, 2017 at 3:40 PM, <thakis@chromium.org> wrote:

> More follow-up to that NewOverflow change :-)
>
> https://codereview.chromium.org/2694173005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sigurður Ásgeirsson, 2017-02-21 16:43:09]

lgtm - sorry about the tardiness!

[Nico, 2017-02-21 16:43:59]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:44:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:20:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487695439199970,
"parent_rev": "243f0901ba9640fb9bae9af1b14124a0b49d5d2b", "commit_rev":
"a71e1c4d8c9bb54716c7ee7f82ce6b99730bb1b7"}

[commit-bot: I haz the power, 2017-02-21 17:21:31]

Description was changed from

==========
Enable SecurityTest.NewOverflow on Linux now that valgrind is gone

BUG=582398,690271
==========

to

==========
Enable SecurityTest.NewOverflow on Linux now that valgrind is gone

BUG=582398,690271

Review-Url: https://codereview.chromium.org/2694173005
Cr-Commit-Position: refs/heads/master@{#451787}
Committed:
https://chromium.googlesource.com/chromium/src/+/a71e1c4d8c9bb54716c7ee7f82ce...
==========

[commit-bot: I haz the power, 2017-02-21 17:21:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a71e1c4d8c9bb54716c7ee7f82ce...