Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2694163003: [tools/perf] Prepare V8DetachedContextAgeInGCTests for JS API migration (Closed)

Created:
3 years, 10 months ago by perezju
Modified:
3 years, 10 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Prepare V8DetachedContextAgeInGCTests for JS API migration A previous attempt to land https://codereview.chromium.org/2687773003/ broke the catapult roll due to V8DetachedContextAgeInGCTests failures. These tests use a FakeTab and poke at the arguments of calls to EvaluateJavaScript in order to return fake histograms. The signature and implementaion of the fake method is tweaked in order to work both with the old and new JS APIs. BUG=catapult:#3208 Review-Url: https://codereview.chromium.org/2694163003 Cr-Commit-Position: refs/heads/master@{#450341} Committed: https://chromium.googlesource.com/chromium/src/+/edebc1fbd29714dce0151bfa57a08b49eea5293d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py View 1 chunk +7 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
perezju
https://codereview.chromium.org/2694163003/diff/1/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py File tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py (right): https://codereview.chromium.org/2694163003/diff/1/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py#newcode32 tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py:32: if kwargs.get('name') == histogram_name or histogram_name in script: Tweaked ...
3 years, 10 months ago (2017-02-14 11:42:05 UTC) #2
nednguyen
lgtm
3 years, 10 months ago (2017-02-14 13:46:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694163003/1
3 years, 10 months ago (2017-02-14 13:50:04 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 13:54:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/edebc1fbd29714dce0151bfa57a0...

Powered by Google App Engine
This is Rietveld 408576698