Handle retained printing history.

Handle retained printing history.

In order to accurately report errors, CUPS on Chrome OS is going to
retain history.  Previously, the notification code assumed that
completed jobs were removed from history but this prevents the accurate
reporting of jobs that failed due to errors.

BUG=684853
Review-Url: https://codereview.chromium.org/2694123002
Cr-Commit-Position: refs/heads/master@{#450738}
Committed: https://chromium.googlesource.com/chromium/src/+/d440b845e1f0f93c6637cb86994ec69faf60cba6

[skau, 2017-02-14 19:38:46]

skau@chromium.org changed reviewers:
+ justincarlson@chromium.org

[skau, 2017-02-14 19:38:47]

This is the first of several CLs to improve error reporting for ongoing print
jobs.

[Carlson, 2017-02-14 21:00:28]

lgtm

[skau, 2017-02-14 21:53:45]

The CQ bit was checked by skau@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:54:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 21:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:54:37]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[skau, 2017-02-14 22:01:22]

skau@chromium.org changed reviewers:
+ xdai@chromium.org

[skau, 2017-02-14 22:01:23]

It seems that justin is not enough.  xdai@, can you take a look?

[xdai1, 2017-02-14 22:39:13]

lgtm

[skau, 2017-02-15 17:00:31]

The CQ bit was checked by skau@chromium.org

[commit-bot: I haz the power, 2017-02-15 17:01:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 17:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487178031491410, "parent_rev":
"3b072d101e10142e0f427d198c62799e344a7190", "commit_rev":
"d440b845e1f0f93c6637cb86994ec69faf60cba6"}

[commit-bot: I haz the power, 2017-02-15 17:30:18]

Description was changed from

==========
Handle retained printing history.

In order to accurately report errors, CUPS on Chrome OS is going to
retain history.  Previously, the notification code assumed that
completed jobs were removed from history but this prevents the accurate
reporting of jobs that failed due to errors.

BUG=684853
==========

to

==========
Handle retained printing history.

In order to accurately report errors, CUPS on Chrome OS is going to
retain history.  Previously, the notification code assumed that
completed jobs were removed from history but this prevents the accurate
reporting of jobs that failed due to errors.

BUG=684853

Review-Url: https://codereview.chromium.org/2694123002
Cr-Commit-Position: refs/heads/master@{#450738}
Committed:
https://chromium.googlesource.com/chromium/src/+/d440b845e1f0f93c6637cb86994e...
==========

[commit-bot: I haz the power, 2017-02-15 17:30:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d440b845e1f0f93c6637cb86994e...