Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2355)

Unified Diff: runtime/bin/isolate_data.h

Issue 2694103004: Cleanup app snapshots on isolate/vm exit. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/isolate_data.h
diff --git a/runtime/bin/isolate_data.h b/runtime/bin/isolate_data.h
index 5ed1ed864f6398bfeb4ff04474587a72205e1841..99a3b9b16602e078057b9ccb6ece3a9c57658792 100644
--- a/runtime/bin/isolate_data.h
+++ b/runtime/bin/isolate_data.h
@@ -15,6 +15,7 @@ namespace bin {
// Forward declaration.
class EventHandler;
class Loader;
+class AppSnapshot;
zra 2017/02/15 04:41:40 Alphabetize.
rmacnak 2017/02/16 03:05:30 Done.
// Data associated with every isolate in the standalone VM
// embedding. This is used to free external resources for each isolate
@@ -23,34 +24,9 @@ class IsolateData {
public:
IsolateData(const char* url,
const char* package_root,
- const char* packages_file)
- : script_url((url != NULL) ? strdup(url) : NULL),
- package_root(NULL),
- packages_file(NULL),
- udp_receive_buffer(NULL),
- builtin_lib_(NULL),
- loader_(NULL) {
- if (package_root != NULL) {
- ASSERT(packages_file == NULL);
- this->package_root = strdup(package_root);
- } else if (packages_file != NULL) {
- this->packages_file = strdup(packages_file);
- }
- }
-
- ~IsolateData() {
- free(script_url);
- script_url = NULL;
- free(package_root);
- package_root = NULL;
- free(packages_file);
- packages_file = NULL;
- free(udp_receive_buffer);
- udp_receive_buffer = NULL;
- if (builtin_lib_ != NULL) {
- Dart_DeletePersistentHandle(builtin_lib_);
- }
- }
+ const char* packages_file,
+ AppSnapshot* app_snapshot);
+ ~IsolateData();
Dart_Handle builtin_lib() const {
ASSERT(builtin_lib_ != NULL);
@@ -83,6 +59,7 @@ class IsolateData {
private:
Dart_Handle builtin_lib_;
Loader* loader_;
+ AppSnapshot* app_snapshot_;
DISALLOW_COPY_AND_ASSIGN(IsolateData);
};

Powered by Google App Engine
This is Rietveld 408576698