Cleanup app snapshots on isolate/vm exit.

runtime/bin/isolate_data.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_BIN_ISOLATE_DATA_H_
 #define RUNTIME_BIN_ISOLATE_DATA_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/globals.h"
 
 namespace dart {
 namespace bin {
 
 // Forward declaration.
 class EventHandler;
 class Loader;
+class AppSnapshot;

[zra, 2017/02/15 04:41:40]

Alphabetize.

[rmacnak, 2017/02/16 03:05:30]

Done.

 
 // Data associated with every isolate in the standalone VM
 // embedding. This is used to free external resources for each isolate
 // when the isolate shuts down.
 class IsolateData {
  public:
   IsolateData(const char* url,
               const char* package_root,
-              const char* packages_file)
-      : script_url((url != NULL) ? strdup(url) : NULL),
-        package_root(NULL),
-        packages_file(NULL),
-        udp_receive_buffer(NULL),
-        builtin_lib_(NULL),
-        loader_(NULL) {
-    if (package_root != NULL) {
-      ASSERT(packages_file == NULL);
-      this->package_root = strdup(package_root);
-    } else if (packages_file != NULL) {
-      this->packages_file = strdup(packages_file);
-    }
-  }
-
-  ~IsolateData() {
-    free(script_url);
-    script_url = NULL;
-    free(package_root);
-    package_root = NULL;
-    free(packages_file);
-    packages_file = NULL;
-    free(udp_receive_buffer);
-    udp_receive_buffer = NULL;
-    if (builtin_lib_ != NULL) {
-      Dart_DeletePersistentHandle(builtin_lib_);
-    }
-  }
+              const char* packages_file,
+              AppSnapshot* app_snapshot);
+  ~IsolateData();
 
   Dart_Handle builtin_lib() const {
     ASSERT(builtin_lib_ != NULL);
     ASSERT(!Dart_IsError(builtin_lib_));
     return builtin_lib_;
   }
   void set_builtin_lib(Dart_Handle lib) {
     ASSERT(builtin_lib_ == NULL);
     ASSERT(lib != NULL);
     ASSERT(!Dart_IsError(lib));
@@ skipping 12 matching lines @@
     return loader_;
   }
   void set_loader(Loader* loader) {
     ASSERT((loader_ == NULL) || (loader == NULL));
     loader_ = loader;
   }
 
  private:
   Dart_Handle builtin_lib_;
   Loader* loader_;
+  AppSnapshot* app_snapshot_;
 
   DISALLOW_COPY_AND_ASSIGN(IsolateData);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // RUNTIME_BIN_ISOLATE_DATA_H_