Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2694103004: Cleanup app snapshots on isolate/vm exit. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 8

Patch Set 5 : . #

Patch Set 6 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -150 lines) Patch
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/extensions.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/extensions_android.cc View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/extensions_fuchsia.cc View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/extensions_linux.cc View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/extensions_macos.cc View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/extensions_win.cc View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/file.h View 2 chunks +18 lines, -1 line 0 comments Download
M runtime/bin/file_android.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/file_linux.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/bin/file_win.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 4 5 5 chunks +16 lines, -9 lines 0 comments Download
M runtime/bin/isolate_data.h View 1 2 3 4 3 chunks +5 lines, -28 lines 0 comments Download
A runtime/bin/isolate_data.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 7 chunks +17 lines, -14 lines 0 comments Download
M runtime/bin/snapshot_utils.h View 2 chunks +17 lines, -5 lines 0 comments Download
M runtime/bin/snapshot_utils.cc View 1 2 3 4 2 chunks +141 lines, -75 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-14 22:54:39 UTC) #2
zra
https://codereview.chromium.org/2694103004/diff/60001/runtime/bin/extensions_android.cc File runtime/bin/extensions_android.cc (right): https://codereview.chromium.org/2694103004/diff/60001/runtime/bin/extensions_android.cc#newcode31 runtime/bin/extensions_android.cc:31: void Extensions::UnloadLibrary(void* lib_handle) { Two newlines between functions. https://codereview.chromium.org/2694103004/diff/60001/runtime/bin/extensions_android.cc#newcode32 ...
3 years, 10 months ago (2017-02-15 04:41:40 UTC) #3
rmacnak
https://codereview.chromium.org/2694103004/diff/60001/runtime/bin/extensions_android.cc File runtime/bin/extensions_android.cc (right): https://codereview.chromium.org/2694103004/diff/60001/runtime/bin/extensions_android.cc#newcode31 runtime/bin/extensions_android.cc:31: void Extensions::UnloadLibrary(void* lib_handle) { On 2017/02/15 04:41:40, zra wrote: ...
3 years, 10 months ago (2017-02-16 03:05:30 UTC) #4
zra
lgtm
3 years, 10 months ago (2017-02-16 03:46:57 UTC) #5
rmacnak
3 years, 10 months ago (2017-02-16 21:55:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
a317b90d6384478d8273e76a9ab76be5806670d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698