Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/common/crash_keys.cc

Issue 2694083004: Fix minidump-generation for debug builds. (Closed)
Patch Set: Fix Primiano's comments (some inline comments + #if-block refactoring). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/crash_keys.cc
diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc
index 4ce7af6eee46dfce34a5d0e679a40aa382dc5acc..816be58b984906649b30b0b4685f1688e44a7f09 100644
--- a/chrome/common/crash_keys.cc
+++ b/chrome/common/crash_keys.cc
@@ -100,8 +100,10 @@ size_t RegisterChromeCrashKeys() {
// The following keys may be chunked by the underlying crash logging system,
// but ultimately constitute a single key-value pair.
//
- // If you're adding keys here, please also add them to the following list:
- // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper().
+ // If you're adding keys here, please also add them to the following lists:
+ // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper(),
+ // android_webview/common/crash_reporter/crash_keys.cc::
+ // RegisterWebViewCrashKeys().
Tobias Sargeant 2017/02/20 11:47:18 It should probably be something more along the lin
gsennton 2017/02/22 15:52:11 Done.
base::debug::CrashKey fixed_keys[] = {
#if defined(OS_MACOSX) || defined(OS_WIN)
{ kMetricsClientId, kSmallSize },

Powered by Google App Engine
This is Rietveld 408576698