Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 2694083004: Fix minidump-generation for debug builds. (Closed)
Patch Set: Fix Primiano's comments (some inline comments + #if-block refactoring). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 #endif 93 #endif
94 94
95 const char kViewCount[] = "view-count"; 95 const char kViewCount[] = "view-count";
96 96
97 const char kZeroEncodeDetails[] = "zero-encode-details"; 97 const char kZeroEncodeDetails[] = "zero-encode-details";
98 98
99 size_t RegisterChromeCrashKeys() { 99 size_t RegisterChromeCrashKeys() {
100 // The following keys may be chunked by the underlying crash logging system, 100 // The following keys may be chunked by the underlying crash logging system,
101 // but ultimately constitute a single key-value pair. 101 // but ultimately constitute a single key-value pair.
102 // 102 //
103 // If you're adding keys here, please also add them to the following list: 103 // If you're adding keys here, please also add them to the following lists:
104 // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper(). 104 // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper(),
105 // android_webview/common/crash_reporter/crash_keys.cc::
106 // RegisterWebViewCrashKeys().
Tobias Sargeant 2017/02/20 11:47:18 It should probably be something more along the lin
gsennton 2017/02/22 15:52:11 Done.
105 base::debug::CrashKey fixed_keys[] = { 107 base::debug::CrashKey fixed_keys[] = {
106 #if defined(OS_MACOSX) || defined(OS_WIN) 108 #if defined(OS_MACOSX) || defined(OS_WIN)
107 { kMetricsClientId, kSmallSize }, 109 { kMetricsClientId, kSmallSize },
108 #else 110 #else
109 { kClientId, kSmallSize }, 111 { kClientId, kSmallSize },
110 #endif 112 #endif
111 { kChannel, kSmallSize }, 113 { kChannel, kSmallSize },
112 { kActiveURL, kLargeSize }, 114 { kActiveURL, kLargeSize },
113 { kNumVariations, kSmallSize }, 115 { kNumVariations, kSmallSize },
114 { kVariations, kHugeSize }, 116 { kVariations, kHugeSize },
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 } 377 }
376 378
377 ScopedPrinterInfo::~ScopedPrinterInfo() { 379 ScopedPrinterInfo::~ScopedPrinterInfo() {
378 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 380 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
379 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 381 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
380 base::debug::ClearCrashKey(key); 382 base::debug::ClearCrashKey(key);
381 } 383 }
382 } 384 }
383 385
384 } // namespace crash_keys 386 } // namespace crash_keys
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698