Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2694063005: [HEAP] Remove SIMD 128 bit alignment from heap. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
Michael Lippautz, Yang
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[HEAP] Remove SIMD 128 bit alignment from heap. LOG=N BUG=v8:4124, v8:5948 Review-Url: https://codereview.chromium.org/2694063005 Cr-Commit-Position: refs/heads/master@{#43219} Committed: https://chromium.googlesource.com/v8/v8/+/717c8f2c766fab803ea2ad37c4e1bd885f48ad90

Patch Set 1 #

Patch Set 2 : Eliminate unused local from test. #

Total comments: 2

Patch Set 3 : Restore deleted bounds check in deserializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -125 lines) Patch
M src/globals.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/snapshot/deserializer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 4 chunks +16 lines, -108 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
bbudge
3 years, 10 months ago (2017-02-14 21:13:28 UTC) #10
Yang
https://codereview.chromium.org/2694063005/diff/20001/src/snapshot/deserializer.h File src/snapshot/deserializer.h (left): https://codereview.chromium.org/2694063005/diff/20001/src/snapshot/deserializer.h#oldcode87 src/snapshot/deserializer.h:87: DCHECK_LE(alignment, kSimd128Unaligned); please do not remove this check, but ...
3 years, 10 months ago (2017-02-14 21:32:00 UTC) #12
bbudge
https://codereview.chromium.org/2694063005/diff/20001/src/snapshot/deserializer.h File src/snapshot/deserializer.h (left): https://codereview.chromium.org/2694063005/diff/20001/src/snapshot/deserializer.h#oldcode87 src/snapshot/deserializer.h:87: DCHECK_LE(alignment, kSimd128Unaligned); On 2017/02/14 21:32:00, Yang wrote: > please ...
3 years, 10 months ago (2017-02-14 22:18:51 UTC) #15
Yang
src/snapshot lgtm.
3 years, 10 months ago (2017-02-15 09:53:40 UTC) #18
Michael Lippautz
lgtm
3 years, 10 months ago (2017-02-15 15:16:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694063005/40001
3 years, 10 months ago (2017-02-15 15:40:49 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 15:42:36 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/717c8f2c766fab803ea2ad37c4e1bd885f4...

Powered by Google App Engine
This is Rietveld 408576698