Make CanvasPainter raster directly to an SkBitmap

ui/views/drag_utils.h

Index: ui/views/drag_utils.h
diff --git a/ui/views/drag_utils.h b/ui/views/drag_utils.h
index 158f5cdecab0070130b6631a52995416dea87b8a..5e54e61335d8d24129f975cf1c6366cc8dc24031 100644
--- a/ui/views/drag_utils.h
+++ b/ui/views/drag_utils.h
@@ -29,6 +29,10 @@ VIEWS_EXPORT void RunShellDrag(gfx::NativeView view,
                                int operation,
                                ui::DragDropTypes::DragEventSource source);
 
+// Returns the device scale for the display associated with the native
+// view associated with this widget.

[tapted, 2017/02/14 23:34:07]

nit: Widget (or |widget|) -> perhaps ".. the display associated with |widget|'s
native view."

+VIEWS_EXPORT float GetDeviceScaleForNativeView(views::Widget* widget);

[tapted, 2017/02/14 23:34:07]

nit: views:: not required

[tapted, 2017/02/14 23:34:08]

The name of this method feels too generic now that it's exposed in the .h. Maybe
ScaleFactorForDragFromWidget() ?

+
 // Returns a canvas that can be used to draw the drag image. Caller owns the
 // returned object. |widget| is Widget hosting the view being dragged.
 VIEWS_EXPORT gfx::Canvas* GetCanvasForDragImage(Widget* widget,

[tapted, 2017/02/14 23:34:07]

(not much uses this any more (just menu_controller.cc). I looked for ways we
might drop some of the boilerplate by changing this to return a gfx::ImageSkia
or similar, but that's probably not going to work :/).

[enne (OOO), 2017/02/15 00:02:05]

I looked at that as well and saw that it couldn't quite get removed yet.