Make CanvasPainter raster directly to an SkBitmap

ui/views/drag_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_DRAG_UTILS_H_
 #define UI_VIEWS_DRAG_UTILS_H_
 
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/views_export.h"
@@ skipping 11 matching lines @@
 namespace views {
 class Widget;
 
 // Starts a drag operation. This blocks until the drag operation completes.
 VIEWS_EXPORT void RunShellDrag(gfx::NativeView view,
                                const ui::OSExchangeData& data,
                                const gfx::Point& location,
                                int operation,
                                ui::DragDropTypes::DragEventSource source);
 
+// Returns the device scale for the display associated with the native
+// view associated with this widget.

[tapted, 2017/02/14 23:34:07]

nit: Widget (or |widget|) -> perhaps ".. the display associated with |widget|'s
native view."

+VIEWS_EXPORT float GetDeviceScaleForNativeView(views::Widget* widget);

[tapted, 2017/02/14 23:34:07]

nit: views:: not required

[tapted, 2017/02/14 23:34:08]

The name of this method feels too generic now that it's exposed in the .h. Maybe
ScaleFactorForDragFromWidget() ?

+
 // Returns a canvas that can be used to draw the drag image. Caller owns the
 // returned object. |widget| is Widget hosting the view being dragged.
 VIEWS_EXPORT gfx::Canvas* GetCanvasForDragImage(Widget* widget,

[tapted, 2017/02/14 23:34:07]

(not much uses this any more (just menu_controller.cc). I looked for ways we
might drop some of the boilerplate by changing this to return a gfx::ImageSkia
or similar, but that's probably not going to work :/).

[enne (OOO), 2017/02/15 00:02:05]

I looked at that as well and saw that it couldn't quite get removed yet.

                                                 const gfx::Size& canvas_size);
 
 }  // namespace views
 
 #endif  // UI_VIEWS_DRAG_UTILS_H_