Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoader.h

Issue 2694013005: Cleanup blink-side PlzNavigate logic (Closed)
Patch Set: Address ananta's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.h b/third_party/WebKit/Source/core/loader/DocumentLoader.h
index ac5e7b73550fd341e906f5e24fdf942fbc32e069..e172bc3fae9447e684bfce22597ea0734850a98a 100644
--- a/third_party/WebKit/Source/core/loader/DocumentLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.h
@@ -134,6 +134,12 @@ class CORE_EXPORT DocumentLoader
return m_state >= Committed && !m_dataReceived;
}
+ // Without PlzNavigate, this is only true for a narrow window during
clamy 2017/03/02 14:37:18 Did you mean "Without PlzNavigate, this is only fa
Nate Chapin 2017/03/02 19:39:17 Yep. Booleans are hard.
+ // navigation start. For PlzNavigate, a navigation sent to the browser will
+ // leave a dummy DocumentLoader in the NotStarted state until the navigation
+ // is actually handled in the renderer.
+ bool didStart() const { return m_state != NotStarted; }
+
void setSentDidFinishLoad() { m_state = SentDidFinishLoad; }
bool sentDidFinishLoad() const { return m_state == SentDidFinishLoad; }

Powered by Google App Engine
This is Rietveld 408576698