Cleanup blink-side PlzNavigate logic

third_party/WebKit/Source/core/loader/FrameLoader.h

Index: third_party/WebKit/Source/core/loader/FrameLoader.h
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.h b/third_party/WebKit/Source/core/loader/FrameLoader.h
index 30988a2e17a4a91d05bbd853c9e2b65a2788c8e0..1ba84850f199c2f9761921944f9c03491f9e27ce 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.h
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.h
@@ -202,23 +202,20 @@ class CORE_EXPORT FrameLoader final {
 
   void restoreScrollPositionAndViewState();
 
-  bool shouldContinueForNavigationPolicy(const ResourceRequest&,
-                                         const SubstituteData&,
-                                         DocumentLoader*,
-                                         ContentSecurityPolicyDisposition,
-                                         NavigationType,
-                                         NavigationPolicy,
-                                         FrameLoadType,
-                                         bool isClientRedirect,
-                                         HTMLFormElement*);
+  NavigationPolicy shouldContinueForNavigationPolicy(

[clamy, 2017/03/02 14:37:18]

Maybe add a comment about which NavigationPolicy should prompt us to continue?

[Nate Chapin, 2017/03/02 19:39:18]

Done.

+      const ResourceRequest&,
+      const SubstituteData&,
+      DocumentLoader*,
+      ContentSecurityPolicyDisposition,
+      NavigationType,
+      NavigationPolicy,
+      FrameLoadType,
+      bool isClientRedirect,
+      HTMLFormElement*);
 
   // PlzNavigate: Navigations handled by the client are treated as
   // provisional navigations.

[clamy, 2017/03/02 14:37:18]

nit: I think the comment should be updated. Maybe something like:
// PlzNavigate
// Note: navigations handled by the client have created a dummy provisional
DocumentLoader, so this will return true while the client handles the
navigation.

[Nate Chapin, 2017/03/02 19:39:18]

Done.

-  bool hasProvisionalNavigation() const {
-    return provisionalDocumentLoader() || m_isNavigationHandledByClient;
-  }
-
-  void clearNavigationHandledByClient();
+  bool hasProvisionalNavigation() const { return provisionalDocumentLoader(); }
 
   DECLARE_TRACE();
 
@@ -238,10 +235,10 @@ class CORE_EXPORT FrameLoader final {
                                        const KURL&);
   void processFragment(const KURL&, FrameLoadType, LoadStartType);
 
-  bool checkLoadCanStart(FrameLoadRequest&,
-                         FrameLoadType,
-                         NavigationPolicy,
-                         NavigationType);
+  NavigationPolicy checkLoadCanStart(FrameLoadRequest&,
+                                     FrameLoadType,
+                                     NavigationPolicy,
+                                     NavigationType);
   void startLoad(FrameLoadRequest&, FrameLoadType, NavigationPolicy);
 
   enum class HistoryNavigationType { DifferentDocument, Fragment, HistoryApi };
@@ -271,8 +268,6 @@ class CORE_EXPORT FrameLoader final {
                                        FrameLoadType,
                                        NavigationType);
 
-  void setNavigationHandledByClient();
-
   Member<LocalFrame> m_frame;
   AtomicString m_requiredCSP;
 
@@ -333,7 +328,6 @@ class CORE_EXPORT FrameLoader final {
 
   bool m_dispatchingDidClearWindowObjectInMainWorld;
   bool m_protectProvisionalLoader;
-  bool m_isNavigationHandledByClient;
 };
 
 }  // namespace blink