Add Javascript-Heavy tags for system health stories with heavy uses of JS

Add Javascript-Heavy tags for system health stories with heavy uses of JS


These stories use 20Mb+ memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run.

BUG=692089
Review-Url: https://codereview.chromium.org/2693973002
Cr-Commit-Position: refs/heads/master@{#450392}
Committed: https://chromium.googlesource.com/chromium/src/+/5c881c966c106de42f6e3b142d555a02771c1913

[nednguyen, 2017-02-13 16:17:03]

Description was changed from

==========
Add Javascript-Heavy tags for system health stories with heavy uses of JS
==========

to

==========
Add Javascript-Heavy tags for system health stories with heavy uses of JS


These stories use 20Mb+ memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run.
==========

[nednguyen, 2017-02-13 16:17:03]

nednguyen@google.com changed reviewers:
+ mythria@chromium.org, perezju@chromium.org, ulan@chromium.org

[nednguyen, 2017-02-13 16:17:26]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 16:18:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2017-02-13 16:29:06]

lgtm

[nednguyen, 2017-02-13 16:32:01]

The CQ bit was unchecked by nednguyen@google.com

[perezju, 2017-02-13 16:32:08]

https://codereview.chromium.org/2693973002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/story_tags.py (right):

https://codereview.chromium.org/2693973002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/story_tags.py:30: 'of JavaScript.')
Can you add here the rationale for considering the JS usage on a page as heavy?
E.g. something like you did on the CL description: "These stories use 20Mb+
memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run."

[perezju, 2017-02-13 16:32:32]

Also please add a bug to the CL description.

[mythria, 2017-02-13 16:35:17]

lgtm.

[commit-bot: I haz the power, 2017-02-13 17:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 17:37:43]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-02-14 15:20:31]

https://codereview.chromium.org/2693973002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/story_tags.py (right):

https://codereview.chromium.org/2693973002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/story_tags.py:30: 'of JavaScript.')
On 2017/02/13 16:32:08, perezju wrote:
> Can you add here the rationale for considering the JS usage on a page as
heavy?
> E.g. something like you did on the CL description: "These stories use 20Mb+
> memory for javascript. Local run with "v8" 
> category enabled also shows their traces have js slices across the whole
> run."

Great idea to document the methodology here. Done.

[nednguyen, 2017-02-14 15:22:59]

Description was changed from

==========
Add Javascript-Heavy tags for system health stories with heavy uses of JS


These stories use 20Mb+ memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run.
==========

to

==========
Add Javascript-Heavy tags for system health stories with heavy uses of JS


These stories use 20Mb+ memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run.

BUG=692089
==========

[nednguyen, 2017-02-14 15:23:22]

On 2017/02/14 15:20:31, nednguyen wrote:
>
https://codereview.chromium.org/2693973002/diff/1/tools/perf/page_sets/system...
> File tools/perf/page_sets/system_health/story_tags.py (right):
> 
>
https://codereview.chromium.org/2693973002/diff/1/tools/perf/page_sets/system...
> tools/perf/page_sets/system_health/story_tags.py:30: 'of JavaScript.')
> On 2017/02/13 16:32:08, perezju wrote:
> > Can you add here the rationale for considering the JS usage on a page as
> heavy?
> > E.g. something like you did on the CL description: "These stories use 20Mb+
> > memory for javascript. Local run with "v8" 
> > category enabled also shows their traces have js slices across the whole
> > run."
> 
> Great idea to document the methodology here. Done.

PTAL again Juan

[perezju, 2017-02-14 15:43:39]

lgtm w/nit, thanks!

https://codereview.chromium.org/2693973002/diff/20001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/story_tags.py (right):

https://codereview.chromium.org/2693973002/diff/20001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/story_tags.py:31: 'run with "v8" category
enabled also shows the trace have js slices across '
nit: "shows the trace have js slices" -> s/have/has/

[nednguyen, 2017-02-14 15:47:26]

https://codereview.chromium.org/2693973002/diff/20001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/story_tags.py (right):

https://codereview.chromium.org/2693973002/diff/20001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/story_tags.py:31: 'run with "v8" category
enabled also shows the trace have js slices across '
On 2017/02/14 15:43:39, perezju wrote:
> nit: "shows the trace have js slices" -> s/have/has/

Done.

[nednguyen, 2017-02-14 15:47:29]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-02-14 15:47:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
mythria@chromium.org, perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/2693973002/#ps40001
(title: "address Juan's nit")

[commit-bot: I haz the power, 2017-02-14 15:47:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 15:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 15:50:00]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[nednguyen, 2017-02-14 15:56:27]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-02-14 15:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
perezju@chromium.org, ulan@chromium.org, mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2693973002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-14 15:57:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 17:18:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487087787209400,
"parent_rev": "6a5106048c624b4ae8421a1f88e7cbe4d7e85869", "commit_rev":
"5c881c966c106de42f6e3b142d555a02771c1913"}

[commit-bot: I haz the power, 2017-02-14 17:18:38]

Description was changed from

==========
Add Javascript-Heavy tags for system health stories with heavy uses of JS


These stories use 20Mb+ memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run.

BUG=692089
==========

to

==========
Add Javascript-Heavy tags for system health stories with heavy uses of JS


These stories use 20Mb+ memory for javascript. Local run with "v8" 
category enabled also shows their traces have js slices across the whole
run.

BUG=692089

Review-Url: https://codereview.chromium.org/2693973002
Cr-Commit-Position: refs/heads/master@{#450392}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c881c966c106de42f6e3b142d55...
==========

[commit-bot: I haz the power, 2017-02-14 17:18:39]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5c881c966c106de42f6e3b142d55...