Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2693933002: Network traffic annotation added to PrivetV3Session. (Closed)

Created:
2 years, 7 months ago by Ramin Halavati
Modified:
2 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, msramek, battre
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to PrivetV3Session. Network traffic annotation is added to network request of PrivetV3Session. BUG=656607 Review-Url: https://codereview.chromium.org/2693933002 Cr-Commit-Position: refs/heads/master@{#450330} Committed: https://chromium.googlesource.com/chromium/src/+/ba86e8b1570210b191884e1c2534a2844aeac42e

Patch Set 1 #

Patch Set 2 : No-Annotaion flag added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/extensions/api/gcd_private/privet_v3_context_getter_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_session.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Ramin Halavati
We are annotating all network requests in Chromium with a new NetworkTrafficAnnotation scheme. This allows ...
2 years, 7 months ago (2017-02-13 14:27:45 UTC) #2
Vitaly Buka (NO REVIEWS)
I just received confirmation that Privetv3 is unused. Could you fill that with some reasonable ...
2 years, 7 months ago (2017-02-13 21:35:41 UTC) #3
Ramin Halavati
Thanks Vitaly. A temporary flag for no annotation added. Please review.
2 years, 7 months ago (2017-02-14 11:44:59 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
2 years, 7 months ago (2017-02-14 11:46:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693933002/20001
2 years, 7 months ago (2017-02-14 11:52:07 UTC) #10
commit-bot: I haz the power
2 years, 7 months ago (2017-02-14 12:30:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba86e8b1570210b191884e1c2534...

Powered by Google App Engine
This is Rietveld 408576698