Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2693913002: [IC] Also use LoadNonexistentDH for keyed loads (Closed)

Created:
3 years, 10 months ago by Toon Verwaest
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[IC] Also use LoadNonexistentDH for keyed loads Unlike the old manually written LoadNonexistent stub, the data handler properly supports keyed loads out of the box. Simply remove the condition that disables it. BUG= Review-Url: https://codereview.chromium.org/2693913002 Cr-Commit-Position: refs/heads/master@{#43165} Committed: https://chromium.googlesource.com/v8/v8/+/d891b500535b1833d03f25e878bffede56ad3abc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/ic/ic.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Toon Verwaest
ptal
3 years, 10 months ago (2017-02-13 13:39:34 UTC) #4
Igor Sheludko
lgtm
3 years, 10 months ago (2017-02-13 15:20:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693913002/1
3 years, 10 months ago (2017-02-13 16:12:46 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 18:49:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d891b500535b1833d03f25e878bffede56a...

Powered by Google App Engine
This is Rietveld 408576698