Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2693893004: Fix two problems with the analyzer suite: (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, karlklose
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix two problems with the analyzer suite: * Don't complain about no tests configured when only analyzing. * Run analyzer on all tests, no only those that have been selected for running. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/0d55f1b8fc36e3e755ee216e2b5308a42084ca94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -33 lines) Patch
M pkg/testing/lib/src/run.dart View 3 chunks +56 lines, -21 lines 0 comments Download
M pkg/testing/lib/src/run_tests.dart View 2 chunks +6 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 10 months ago (2017-02-13 14:39:07 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-14 10:31:28 UTC) #3
ahe
3 years, 10 months ago (2017-02-14 11:02:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d55f1b8fc36e3e755ee216e2b5308a42084ca94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698