Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2693893002: Add a new kind of suite to ease test.dart integration. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, karlklose, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't timeout test.dart suite. #

Total comments: 4

Patch Set 3 : Fix Linux and Windows paths. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -74 lines) Patch
D pkg/front_end/test/fasta/dart2js_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 8 chunks +23 lines, -2 lines 0 comments Download
M pkg/testing/lib/src/chain.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/testing/lib/src/run.dart View 2 chunks +13 lines, -1 line 0 comments Download
M pkg/testing/lib/src/stdio_process.dart View 1 3 chunks +42 lines, -19 lines 0 comments Download
M pkg/testing/lib/src/suite.dart View 2 chunks +6 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_dart.dart View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A tools/testing/dart/package_testing_support.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
3 years, 10 months ago (2017-02-13 13:30:04 UTC) #2
ahe
FYI: I uploaded a new patch set.
3 years, 10 months ago (2017-02-13 14:04:34 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2693893002/diff/20001/pkg/testing/lib/src/test_dart.dart File pkg/testing/lib/src/test_dart.dart (right): https://codereview.chromium.org/2693893002/diff/20001/pkg/testing/lib/src/test_dart.dart#newcode49 pkg/testing/lib/src/test_dart.dart:49: dartVm = Uri.base.resolve("tools/sdks/linux/dart-sdk/bin/dart"); linux -> win /dart -> ...
3 years, 10 months ago (2017-02-14 08:22:50 UTC) #4
ahe
Thank you, great catch! https://codereview.chromium.org/2693893002/diff/20001/pkg/testing/lib/src/test_dart.dart File pkg/testing/lib/src/test_dart.dart (right): https://codereview.chromium.org/2693893002/diff/20001/pkg/testing/lib/src/test_dart.dart#newcode49 pkg/testing/lib/src/test_dart.dart:49: dartVm = Uri.base.resolve("tools/sdks/linux/dart-sdk/bin/dart"); On 2017/02/14 ...
3 years, 10 months ago (2017-02-14 09:40:29 UTC) #5
ahe
3 years, 10 months ago (2017-02-14 09:45:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cb10fc984bde415be0df5d98e473953ff787a41a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698