Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2693873004: Integration test of Data Saver block-once directive (Closed)

Created:
3 years, 10 months ago by bengr
Modified:
3 years, 10 months ago
Reviewers:
Robert Ogden, RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Integration test of Data Saver block-once directive The added test checks that a test HTML resource is not served via the Data Saver proxy and that a subresource referenced in the HTML is served via the proxy. The proxy is configured to respond with the 'block-once' directive (a field of the Chrome-Proxy header) if the test HTML resource is requested. BUG=680574 Review-Url: https://codereview.chromium.org/2693873004 Cr-Commit-Position: refs/heads/master@{#450142} Committed: https://chromium.googlesource.com/chromium/src/+/3f40be110899bd6c3a4dc9a90daa10ba8adfe12c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/chrome_proxy/webdriver/bypass.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bengr
PTAL
3 years, 10 months ago (2017-02-13 22:31:07 UTC) #4
Robert Ogden
lgtm
3 years, 10 months ago (2017-02-13 22:33:09 UTC) #5
RyanSturm
lgtm
3 years, 10 months ago (2017-02-13 22:49:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693873004/40001
3 years, 10 months ago (2017-02-13 22:57:39 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 23:14:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3f40be110899bd6c3a4dc9a90daa...

Powered by Google App Engine
This is Rietveld 408576698