Fix flakiness in webaudio/Oscillator/oscillator-late-start.html

Fix flakiness in webaudio/Oscillator/oscillator-late-start.html

This test uses a hacky method to trigger a function after the render
starts on OfflineAudioContext. This CL replaces such method of using
'onstatechange' with the suspension of OfflineAudioContext.


BUG=691425
TEST=
webaudio/Oscillator/oscillator-late-start.html

Review-Url: https://codereview.chromium.org/2693853004
Cr-Commit-Position: refs/heads/master@{#450158}
Committed: https://chromium.googlesource.com/chromium/src/+/a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98

[hongchan, 2017-02-13 21:09:06]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-02-13 21:09:07]

PTAL.

[Raymond Toy, 2017-02-13 21:51:44]

https://codereview.chromium.org/2693853004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js
(right):

https://codereview.chromium.org/2693853004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js:1:
function runLateStartTest(audit, Should, context, node) {
IIRC, Should() is a global function.  Does it need to be passed in?

[hongchan, 2017-02-13 22:08:31]

https://codereview.chromium.org/2693853004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js
(right):

https://codereview.chromium.org/2693853004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js:1:
function runLateStartTest(audit, Should, context, node) {
On 2017/02/13 21:51:44, Raymond Toy wrote:
> IIRC, Should() is a global function.  Does it need to be passed in?

Done.

[Raymond Toy, 2017-02-13 22:13:02]

lgtm with nits.

https://codereview.chromium.org/2693853004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js
(right):

https://codereview.chromium.org/2693853004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js:39:
.notBeEqualTo(-1);
Nit: this is not a great message to print out. Don't have a really good
suggestion.

https://codereview.chromium.org/2693853004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js:41:
.notBeEqualTo(0) && success;
Maybe say 'First non-zero value found at index'. Or something.

[hongchan, 2017-02-13 22:32:54]

Patchset #3 (id:40001) has been deleted

[hongchan, 2017-02-13 22:33:58]

https://codereview.chromium.org/2693853004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js
(right):

https://codereview.chromium.org/2693853004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js:39:
.notBeEqualTo(-1);
On 2017/02/13 22:13:01, Raymond Toy wrote:
> Nit: this is not a great message to print out. Don't have a really good
> suggestion.

Done.

https://codereview.chromium.org/2693853004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js:41:
.notBeEqualTo(0) && success;
On 2017/02/13 22:13:02, Raymond Toy wrote:
> Maybe say 'First non-zero value found at index'. Or something.

I changed it in a slightly different way.

[hongchan, 2017-02-13 22:34:34]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-02-13 22:34:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2693853004/#ps60001
(title: "Fixed assertion message after l-g-t-m")

[commit-bot: I haz the power, 2017-02-13 22:35:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:55:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487025274695630,
"parent_rev": "26a6e0af4ae40ca6cd0379610fc58b211c27785b", "commit_rev":
"a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98"}

[commit-bot: I haz the power, 2017-02-13 23:56:08]

Description was changed from

==========
Fix flakiness in webaudio/Oscillator/oscillator-late-start.html

This test uses a hacky method to trigger a function after the render
starts on OfflineAudioContext. This CL replaces such method of using
'onstatechange' with the suspension of OfflineAudioContext.


BUG=691425
TEST=
webaudio/Oscillator/oscillator-late-start.html
==========

to

==========
Fix flakiness in webaudio/Oscillator/oscillator-late-start.html

This test uses a hacky method to trigger a function after the render
starts on OfflineAudioContext. This CL replaces such method of using
'onstatechange' with the suspension of OfflineAudioContext.


BUG=691425
TEST=
webaudio/Oscillator/oscillator-late-start.html

Review-Url: https://codereview.chromium.org/2693853004
Cr-Commit-Position: refs/heads/master@{#450158}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8b78a341cd4b8d3aff4a4a6ba00...
==========

[commit-bot: I haz the power, 2017-02-13 23:56:09]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a8b78a341cd4b8d3aff4a4a6ba00...