aura-mus: Implement DesktopWindowTreeHostMus::SetOpacity().

aura-mus: Implement DesktopWindowTreeHostMus::SetOpacity().

Also ensures that the views_examples program still works in mash, which
was used for testing.

BUG=663619
TEST=DesktopWindowTreeHostMusTest.SetOpacity

Review-Url: https://codereview.chromium.org/2693823004
Cr-Commit-Position: refs/heads/master@{#450214}
Committed: https://chromium.googlesource.com/chromium/src/+/18ba644c962b669f3465ff7d44588f15acd5c72c

[Elliot Glaysher, 2017-02-13 22:33:32]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-13 23:38:13]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 23:38:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-13 23:38:29]

Description was changed from

==========
aura-mus: Implement DesktopWindowTreeHostMus::SetOpacity().

Also ensures that the views_examples program still works in mash, which
was used for testing.

BUG=663619
==========

to

==========
aura-mus: Implement DesktopWindowTreeHostMus::SetOpacity().

Also ensures that the views_examples program still works in mash, which
was used for testing.

BUG=663619
TEST=DesktopWindowTreeHostMusTest.SetOpacity
==========

[Elliot Glaysher, 2017-02-14 00:05:22]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-02-14 00:41:33]

https://codereview.chromium.org/2693823004/diff/20001/chrome/app/mash/BUILD.gn
File chrome/app/mash/BUILD.gn (right):

https://codereview.chromium.org/2693823004/diff/20001/chrome/app/mash/BUILD.g...
chrome/app/mash/BUILD.gn:81: standalone_services = [
"//mash/example/views_examples:manifest" ]
Does this change what is compiled at all? I want to make sure building chrome
doesn't trigger building views_examples.

[sky, 2017-02-14 00:47:22]

I see how this works now. When the client changes the value it's routed to
WindowPortMus::SetOpacityFromServer(), which applies the opacity to the layer.
You should be able to remove the comment in that function now as it no longer
makes sense.

[Elliot Glaysher, 2017-02-14 00:52:28]

https://codereview.chromium.org/2693823004/diff/20001/chrome/app/mash/BUILD.gn
File chrome/app/mash/BUILD.gn (right):

https://codereview.chromium.org/2693823004/diff/20001/chrome/app/mash/BUILD.g...
chrome/app/mash/BUILD.gn:81: standalone_services = [
"//mash/example/views_examples:manifest" ]
On 2017/02/14 00:41:33, sky wrote:
> Does this change what is compiled at all? I want to make sure building chrome
> doesn't trigger building views_examples.

I verified that this doesn't generate views_examples.service, nor are there any
object files in $BUILD/obj/ui/views/examples/.

[Elliot Glaysher, 2017-02-14 00:54:38]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[Elliot Glaysher, 2017-02-14 00:54:54]

Removed comments in WindowPortMus::SetOpacityFromServer.

[sky, 2017-02-14 00:55:12]

Excellent, LGTM

[commit-bot: I haz the power, 2017-02-14 00:55:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-14 00:55:48]

The CQ bit was unchecked by erg@chromium.org

[Elliot Glaysher, 2017-02-14 00:55:50]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:56:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 02:54:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487033750620720,
"parent_rev": "7f59d2c0512aae8b641dab53f6a44c407c5f8086", "commit_rev":
"18ba644c962b669f3465ff7d44588f15acd5c72c"}

[commit-bot: I haz the power, 2017-02-14 02:54:52]

Description was changed from

==========
aura-mus: Implement DesktopWindowTreeHostMus::SetOpacity().

Also ensures that the views_examples program still works in mash, which
was used for testing.

BUG=663619
TEST=DesktopWindowTreeHostMusTest.SetOpacity
==========

to

==========
aura-mus: Implement DesktopWindowTreeHostMus::SetOpacity().

Also ensures that the views_examples program still works in mash, which
was used for testing.

BUG=663619
TEST=DesktopWindowTreeHostMusTest.SetOpacity

Review-Url: https://codereview.chromium.org/2693823004
Cr-Commit-Position: refs/heads/master@{#450214}
Committed:
https://chromium.googlesource.com/chromium/src/+/18ba644c962b669f3465ff7d4458...
==========

[commit-bot: I haz the power, 2017-02-14 02:54:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18ba644c962b669f3465ff7d4458...