Remove dependency from NetworkStateNotifier to ExecutionContext

Remove dependency from NetworkStateNotifier to ExecutionContext

As a preparation to move NetworkStateNotifier into platform/network for better
modularization.

Also stop using ExecutionContextTask as it's deprecated now.

BUG=691566
Review-Url: https://codereview.chromium.org/2693823003
Cr-Commit-Position: refs/heads/master@{#450934}
Committed: https://chromium.googlesource.com/chromium/src/+/f1af3fdf3da1e6c1a9b60f747625c288de6f9451

[kinuko, 2017-02-13 14:34:53]

Description was changed from

==========
Remove dependency from NetworkStateNotifier to ExecutionContext

It seems NetworkStateNotifier should be a platform-layer concept and should
not depend on core/.

BUG=691566
==========

to

==========
Remove dependency from NetworkStateNotifier to ExecutionContext

It seems NetworkStateNotifier should be a platform-layer concept and should
not depend on core/.

Also stop using ExecutionContextTask as it's deprecated now.

BUG=691566
==========

[kinuko, 2017-02-14 09:43:08]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 09:43:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-14 11:31:40]

kinuko@chromium.org changed reviewers:
+ jkarlin@chromium.org

[kinuko, 2017-02-14 11:34:48]

Description was changed from

==========
Remove dependency from NetworkStateNotifier to ExecutionContext

It seems NetworkStateNotifier should be a platform-layer concept and should
not depend on core/.

Also stop using ExecutionContextTask as it's deprecated now.

BUG=691566
==========

to

==========
Remove dependency from NetworkStateNotifier to ExecutionContext

As a preparation to move NetworkStateNotifier into platform/network for better
modularization.

Also stop using ExecutionContextTask as it's deprecated now.

BUG=691566
==========

[kinuko, 2017-02-14 11:35:26]

This slightly changes the behavior but should be fine-- could you review?

[commit-bot: I haz the power, 2017-02-14 13:54:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 13:54:59]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2017-02-15 19:26:33]

lgtm with nit, thanks!

https://codereview.chromium.org/2693823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp (right):

https://codereview.chromium.org/2693823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp:149: MutexLocker
locker(m_mutex);
Phew. Thanks for this! Looks like it got deleted in a previous patch and I
missed it.

https://codereview.chromium.org/2693823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp:161: void
NetworkStateNotifier::notifyObserversOfConnectionChangeOnContext(
Please rename this to ...OnTaskRunner

[kinuko, 2017-02-16 03:55:00]

https://codereview.chromium.org/2693823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp (right):

https://codereview.chromium.org/2693823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp:161: void
NetworkStateNotifier::notifyObserversOfConnectionChangeOnContext(
On 2017/02/15 19:26:33, jkarlin wrote:
> Please rename this to ...OnTaskRunner

Done. Thanks =)

[kinuko, 2017-02-16 03:55:09]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-02-16 03:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/2693823003/#ps40001
(title: "rename")

[commit-bot: I haz the power, 2017-02-16 03:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 04:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:08:06]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[kinuko, 2017-02-16 04:29:00]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-02-16 04:29:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/2693823003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-02-16 04:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 06:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:33:43]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[kinuko, 2017-02-16 06:53:17]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:54:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:44:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 08:44:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-02-16 10:09:44]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-02-16 10:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 11:42:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487239784015170,
"parent_rev": "3371166ee6b13e7d34d3a8a216bf041abc3ce9b9", "commit_rev":
"f1af3fdf3da1e6c1a9b60f747625c288de6f9451"}

[commit-bot: I haz the power, 2017-02-16 11:43:10]

Description was changed from

==========
Remove dependency from NetworkStateNotifier to ExecutionContext

As a preparation to move NetworkStateNotifier into platform/network for better
modularization.

Also stop using ExecutionContextTask as it's deprecated now.

BUG=691566
==========

to

==========
Remove dependency from NetworkStateNotifier to ExecutionContext

As a preparation to move NetworkStateNotifier into platform/network for better
modularization.

Also stop using ExecutionContextTask as it's deprecated now.

BUG=691566

Review-Url: https://codereview.chromium.org/2693823003
Cr-Commit-Position: refs/heads/master@{#450934}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1af3fdf3da1e6c1a9b60f747625...
==========

[commit-bot: I haz the power, 2017-02-16 11:43:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f1af3fdf3da1e6c1a9b60f747625...