chrome/browser/lifetime/application_lifetime.cc - Issue 26938003: Don't prompt to save malicious downloads on exit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/application_lifetime.cc

Issue 26938003: Don't prompt to save malicious downloads on exit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed unit test compile error Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/lifetime/application_lifetime.cc

diff --git a/chrome/browser/lifetime/application_lifetime.cc b/chrome/browser/lifetime/application_lifetime.cc

index 0693c58f08a7e48398ecbaeee2248f5ba129c73d..77df8039726c4062ee828e438439a6048534173d 100644

--- a/chrome/browser/lifetime/application_lifetime.cc

+++ b/chrome/browser/lifetime/application_lifetime.cc

@@ -60,7 +60,7 @@ bool AreAllBrowsersCloseable() {

return true;

// If there are any downloads active, all browsers are not closeable.

asanka 2013/10/11 16:02:35 Nit: Mention that dangerous downloads don't block

felt 2013/10/11 17:26:44 Done.

- if (DownloadService::DownloadCountAllProfiles() > 0)

+ if (DownloadService::NonDangerousDownloadCountAllProfiles() > 0)

return false;

// Check TabsNeedBeforeUnloadFired().