chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 26938003: Don't prompt to save malicious downloads on exit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 26938003: Don't prompt to save malicious downloads on exit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed unit test compile error Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_service.h ('K') | « chrome/browser/download/download_service.cc ('k') | chrome/browser/lifetime/application_lifetime.cc » ('j') | chrome/browser/lifetime/application_lifetime.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index f84bf00f11f8955b7423b1efbb25f58a17b04786..79ad47b99d3d19c21ccbdd93016cae80a191e774 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -471,6 +471,7 @@ class DownloadExtensionTest : public ExtensionApiTest {

GURL slow_download_url(URLRequestSlowDownloadJob::kUnknownSizeUrl);

DownloadManager* manager = GetCurrentManager();

+ EXPECT_EQ(0, manager->NonDangerousInProgressCount());

EXPECT_EQ(0, manager->InProgressCount());

if (manager->InProgressCount() != 0)

return NULL;

@@ -3343,6 +3344,7 @@ IN_PROC_BROWSER_TEST_F(

scoped_ptr<content::DownloadTestObserver> observer(

new JustInProgressDownloadObserver(manager, 1));

ASSERT_EQ(0, manager->InProgressCount());

+ ASSERT_EQ(0, manager->NonDangerousInProgressCount());

// Tabs created just for a download are automatically closed, invalidating

// the download's WebContents. Downloads without WebContents cannot be

// resumed. http://crbug.com/225901