Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2693783005: Revert of Linux Aura: Use Aura theme on all windows when 'Use Classic theme' is used (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux Aura: Use Aura theme on all windows when 'Use Classic theme' is used (patchset #6 id:100001 of https://codereview.chromium.org/2667703002/ ) Reason for revert: Browser crash repro: 1. Open browser window 2. Open incognito window 3. Open task manager from incognito window 4. Close incognito window thomasanderson@ and sky@ are currently discussing a solution offline Original issue's description: > Linux Aura: Use Aura theme on all windows when 'Use Classic theme' is used > > Previously, windows like tooltips, context menus, and the task manager > always used the Gtk theme even when "Use Classic theme" was selected > (whereas browser windows would be affected). This CL makes it so the > Aura theme is used on all windows if the classic theme is used. > > BUG=132847 > R=sky@chromium.org,erg@chromium.org > > Review-Url: https://codereview.chromium.org/2667703002 > Cr-Commit-Position: refs/heads/master@{#447312} > Committed: https://chromium.googlesource.com/chromium/src/+/66478cfd170f564932f42a2ca7cbb0b5bf779480 TBR=erg@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=132847 Review-Url: https://codereview.chromium.org/2693783005 Cr-Commit-Position: refs/heads/master@{#450566} Committed: https://chromium.googlesource.com/chromium/src/+/0b3c819b0e36250bf36c04e3d8e2dc9e26317238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +11 lines, -14 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Tom (Use chromium acct)
Created Revert of Linux Aura: Use Aura theme on all windows when 'Use Classic theme' ...
3 years, 10 months ago (2017-02-14 23:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693783005/1
3 years, 10 months ago (2017-02-14 23:43:17 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-14 23:43:18 UTC) #5
Tom (Use chromium acct)
sky ptal
3 years, 10 months ago (2017-02-14 23:44:00 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-02-15 00:44:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693783005/1
3 years, 10 months ago (2017-02-15 01:51:53 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 05:44:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b3c819b0e36250bf36c04e3d8e2...

Powered by Google App Engine
This is Rietveld 408576698