Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++

Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (patchset #6 id:100001 of https://codereview.chromium.org/2671233002/ )

Reason for revert:
Due to security issue described in review thread.

Original issue's description:
> [typedarrays] move %TypedArray%.prototype.copyWithin to C++
> 
> - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
> - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
> relies on std::memmove rather than accessing individual eleements.
> - Fixes the case where copyWithin is invoked on a TypedArray with a
> detached buffer.
> - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled correctly by the
> algorithm
> 
> The C++ version gets through the benchmark more than 25000 times as
> quickly as the JS implementation.
> 
> BUG=v8:5925, v8:5929, v8:4648
> R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2671233002
> Cr-Commit-Position: refs/heads/master@{#42975}
> Committed: https://chromium.googlesource.com/v8/v8/+/0f1c626d556cbf84b0e572635eb803729f88cbb3

TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,cwhan.tunz@gmail.com,caitp@igalia.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5925, v8:5929, v8:4648
Review-Url: https://codereview.chromium.org/2693753002
Cr-Commit-Position: refs/heads/master@{#43132}
Committed: https://chromium.googlesource.com/v8/v8/+/4530f0dc0c27233b05f852c29a6462ab67cbbad2

[Dan Ehrenberg, 2017-02-12 16:08:26]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2017-02-12 16:08:27]

Created Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++

[commit-bot: I haz the power, 2017-02-12 16:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 16:09:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 16:09:40]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17281)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34543)

[caitp, 2017-02-12 17:06:00]

On 2017/02/12 16:09:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
>   v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
>   v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17281)
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34543)

I don't think this is all that pressing of an issue, there isn't much point in a
revert. I'll submit a patch for this tomorrow if it isn't submitted by that
other guy

[Dan Ehrenberg, 2017-02-12 18:48:01]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 18:48:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-02-12 18:59:50]

On 2017/02/12 17:06:00, caitp wrote:
> On 2017/02/12 16:09:40, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
> >   v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
> >   v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17281)
> >   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34543)
> 
> I don't think this is all that pressing of an issue, there isn't much point in
a
> revert. I'll submit a patch for this tomorrow if it isn't submitted by that
> other guy

Well, I think it'd be nicer to minimize the duration of Canary users that are
exposed to this issue. Fixing the conflict was simple, so I'll land this revert.

[commit-bot: I haz the power, 2017-02-12 19:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 19:14:46]

Dry run: This issue passed the CQ dry run.

[caitp, 2017-02-12 20:38:20]

On 2017/02/12 18:59:50, Dan Ehrenberg wrote:
> On 2017/02/12 17:06:00, caitp wrote:
> > On 2017/02/12 16:09:40, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
> > >   v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
> > >   v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
> > >
> http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17281)
> > >   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> > >
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34543)
> > 
> > I don't think this is all that pressing of an issue, there isn't much point
in
> a
> > revert. I'll submit a patch for this tomorrow if it isn't submitted by that
> > other guy
> 
> Well, I think it'd be nicer to minimize the duration of Canary users that are
> exposed to this issue. Fixing the conflict was simple, so I'll land this
revert.

It's a day with something that is not likely to be run into at all, it's really
a minor issue

[Dan Ehrenberg, 2017-02-12 21:14:31]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2017-02-12 21:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 21:16:18]

CQ is committing da patch.

Bot data: {"patchset_id": 190001, "attempt_start_ts": 1486934071396260,
"parent_rev": "32ed62911f6160f5f491bd94edbcd511a5454f1c", "commit_rev":
"4530f0dc0c27233b05f852c29a6462ab67cbbad2"}

[commit-bot: I haz the power, 2017-02-12 21:16:26]

Description was changed from

==========
Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (patchset
#6 id:100001 of https://codereview.chromium.org/2671233002/ )

Reason for revert:
Due to security issue described in review thread.

Original issue's description:
> [typedarrays] move %TypedArray%.prototype.copyWithin to C++
> 
> - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
> - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
> relies on std::memmove rather than accessing individual eleements.
> - Fixes the case where copyWithin is invoked on a TypedArray with a
> detached buffer.
> - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled
correctly by the
> algorithm
> 
> The C++ version gets through the benchmark more than 25000 times as
> quickly as the JS implementation.
> 
> BUG=v8:5925, v8:5929, v8:4648
> R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2671233002
> Cr-Commit-Position: refs/heads/master@{#42975}
> Committed:
https://chromium.googlesource.com/v8/v8/+/0f1c626d556cbf84b0e572635eb803729f8...

TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,cwhan.tunz@gm...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5925, v8:5929, v8:4648
==========

to

==========
Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (patchset
#6 id:100001 of https://codereview.chromium.org/2671233002/ )

Reason for revert:
Due to security issue described in review thread.

Original issue's description:
> [typedarrays] move %TypedArray%.prototype.copyWithin to C++
> 
> - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
> - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
> relies on std::memmove rather than accessing individual eleements.
> - Fixes the case where copyWithin is invoked on a TypedArray with a
> detached buffer.
> - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled
correctly by the
> algorithm
> 
> The C++ version gets through the benchmark more than 25000 times as
> quickly as the JS implementation.
> 
> BUG=v8:5925, v8:5929, v8:4648
> R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2671233002
> Cr-Commit-Position: refs/heads/master@{#42975}
> Committed:
https://chromium.googlesource.com/v8/v8/+/0f1c626d556cbf84b0e572635eb803729f8...

TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,cwhan.tunz@gm...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5925, v8:5929, v8:4648

Review-Url: https://codereview.chromium.org/2693753002
Cr-Commit-Position: refs/heads/master@{#43132}
Committed:
https://chromium.googlesource.com/v8/v8/+/4530f0dc0c27233b05f852c29a6462ab67c...
==========

[commit-bot: I haz the power, 2017-02-12 21:16:27]

Committed patchset #2 (id:190001) as
https://chromium.googlesource.com/v8/v8/+/4530f0dc0c27233b05f852c29a6462ab67c...