Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2693703009:
Fix deprecation warning in MinidumpUploaderTest (Closed)
|
Created:
3 years, 10 months ago by Nate Fischer Modified:
3 years, 10 months ago CC:
android-webview-reviews_chromium.org, chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix deprecation warning in MinidumpUploaderTest
The old package for MediumTest is deprecated. This file must have been
missed by yolandyan@'s CL which did this replacement everywhere:
https://codereview.chromium.org/2583933003
BUG=673824, 640116
Review-Url: https://codereview.chromium.org/2693703009
Cr-Commit-Position: refs/heads/master@{#451152}
Committed: https://chromium.googlesource.com/chromium/src/+/54ba85daadc731cf02047ecda2652a597bebbbf4
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by ntfschr@chromium.org to run a CQ dry run
ntfschr@chromium.org changed reviewers: + yolandyan@chromium.org
yolandyan@: PTAL, since you did the replacement for this. I'll send this off for owners review after your approval.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/02/15 at 21:16:15, Nate Fischer wrote: > yolandyan@: PTAL, since you did the replacement for this. I'll send this off for owners review after your approval. *since you originally did the CL that did the repo-wide replacement for upgrading test annotations (my original wording was unclear)
lgtm
ntfschr@chromium.org changed reviewers: + tobiasjs@chromium.org
tobiasjs@: PTAL for owners approval
ntfschr@chromium.org changed reviewers: + sgurun@chromium.org - tobiasjs@chromium.org
On 2017/02/16 at 03:34:58, Nate Fischer wrote: > tobiasjs@: PTAL for owners approval +sgurun@ for owners approval Just remembered that Toby's OOO
Description was changed from ========== Fix deprecation warning in MinidumpUploaderTest The old package for MediumTest is deprecated. This file must have been missed by yolandyan@'s CL which did this replacement everywhere: https://codereview.chromium.org/2583933003 BUG= ========== to ========== Fix deprecation warning in MinidumpUploaderTest The old package for MediumTest is deprecated. This file must have been missed by yolandyan@'s CL which did this replacement everywhere: https://codereview.chromium.org/2583933003 ==========
Description was changed from ========== Fix deprecation warning in MinidumpUploaderTest The old package for MediumTest is deprecated. This file must have been missed by yolandyan@'s CL which did this replacement everywhere: https://codereview.chromium.org/2583933003 ========== to ========== Fix deprecation warning in MinidumpUploaderTest The old package for MediumTest is deprecated. This file must have been missed by yolandyan@'s CL which did this replacement everywhere: https://codereview.chromium.org/2583933003 BUG=673824, 640116 ==========
lgtm
The CQ bit was checked by ntfschr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487280859835040, "parent_rev":
"172d451b1f1d429ce496c0bb4c57e8e4874cdc43", "commit_rev":
"54ba85daadc731cf02047ecda2652a597bebbbf4"}
Message was sent while issue was closed.
Description was changed from ========== Fix deprecation warning in MinidumpUploaderTest The old package for MediumTest is deprecated. This file must have been missed by yolandyan@'s CL which did this replacement everywhere: https://codereview.chromium.org/2583933003 BUG=673824, 640116 ========== to ========== Fix deprecation warning in MinidumpUploaderTest The old package for MediumTest is deprecated. This file must have been missed by yolandyan@'s CL which did this replacement everywhere: https://codereview.chromium.org/2583933003 BUG=673824, 640116 Review-Url: https://codereview.chromium.org/2693703009 Cr-Commit-Position: refs/heads/master@{#451152} Committed: https://chromium.googlesource.com/chromium/src/+/54ba85daadc731cf02047ecda265... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/54ba85daadc731cf02047ecda265... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
