|
|
Chromium Code Reviews
DescriptionEnable new wpt/referrer-policy tests.
R=jochen@chromium.org, estark@chromium.org
BUG=692105
Review-Url: https://codereview.chromium.org/2693703007
Cr-Commit-Position: refs/heads/master@{#451331}
Committed: https://chromium.googlesource.com/chromium/src/+/13e532004647b3d9fefe0c3643d3741a3c53184e
Patch Set 1 #Patch Set 2 : Rebaseline #
Total comments: 1
Patch Set 3 : Skip directories for policies not yet implemented #Patch Set 4 : Still include expectation for attr-referrer-invalid-value... for now. #Patch Set 5 : Rebased #Patch Set 6 : Rebased #Patch Set 7 : Delete now-not-needed baseline. #Messages
Total messages: 25 (18 generated)
Looks like many of the referrer-policy tests fail when run with run-webkit-tests; is this expected; does this look like it reflects the real behavior of Blink, or might something be wrong with how the tests are run?
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Maybe just skip
external/wpt/referrer-policy/{strict-origin,strict-origin-when-cross-origin,same-origin}
referencing issue 627968 - those policies aren't implemented yet
I'll investigate origin-when-cross-origin
https://codereview.chromium.org/2693703007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):
https://codereview.chromium.org/2693703007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1855: crbug.com/626703
external/wpt/referrer-policy/generic/subresource-test/image-decoding.html [
Timeout ]
both fixed with this PR: https://github.com/w3c/web-platform-tests/pull/4823
oh, the other tests are also testing the same-origin policy. So I guess skipping external/referrer-policy/origin-when-cross-origin/http-rp/same-origin as well makes sense for the first failure, I got a fix in the CQ that should land really soon now
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/15 at 09:57:10, jochen wrote: > oh, the other tests are also testing the same-origin policy. > > So I guess skipping external/referrer-policy/origin-when-cross-origin/http-rp/same-origin as well makes sense > > for the first failure, I got a fix in the CQ that should land really soon now Alright! Does this CL look OK to commit now, with the skips for those four sub-directories of referrer-policy?
lgtm
The CQ bit was unchecked by qyearsley@chromium.org
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 110001, "attempt_start_ts": 1487352099303170,
"parent_rev": "87dd40c9b8ae1fb8c3eb15bf527ee464bd1c1bdd", "commit_rev":
"13e532004647b3d9fefe0c3643d3741a3c53184e"}
Message was sent while issue was closed.
Description was changed from ========== Enable new wpt/referrer-policy tests. R=jochen@chromium.org, estark@chromium.org BUG=692105 ========== to ========== Enable new wpt/referrer-policy tests. R=jochen@chromium.org, estark@chromium.org BUG=692105 Review-Url: https://codereview.chromium.org/2693703007 Cr-Commit-Position: refs/heads/master@{#451331} Committed: https://chromium.googlesource.com/chromium/src/+/13e532004647b3d9fefe0c3643d3... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:110001) as https://chromium.googlesource.com/chromium/src/+/13e532004647b3d9fefe0c3643d3... |
