Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2693703007: Enable new wpt/referrer-policy tests. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable new wpt/referrer-policy tests. R=jochen@chromium.org, estark@chromium.org BUG=692105 Review-Url: https://codereview.chromium.org/2693703007 Cr-Commit-Position: refs/heads/master@{#451331} Committed: https://chromium.googlesource.com/chromium/src/+/13e532004647b3d9fefe0c3643d3741a3c53184e

Patch Set 1 #

Patch Set 2 : Rebaseline #

Total comments: 1

Patch Set 3 : Skip directories for policies not yet implemented #

Patch Set 4 : Still include expectation for attr-referrer-invalid-value... for now. #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased #

Patch Set 7 : Delete now-not-needed baseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 25 (18 generated)
qyearsley
Looks like many of the referrer-policy tests fail when run with run-webkit-tests; is this expected; ...
3 years, 10 months ago (2017-02-14 23:22:52 UTC) #1
jochen (gone - plz use gerrit)
Maybe just skip external/wpt/referrer-policy/{strict-origin,strict-origin-when-cross-origin,same-origin} referencing issue 627968 - those policies aren't implemented yet I'll investigate ...
3 years, 10 months ago (2017-02-15 09:53:50 UTC) #6
jochen (gone - plz use gerrit)
oh, the other tests are also testing the same-origin policy. So I guess skipping external/referrer-policy/origin-when-cross-origin/http-rp/same-origin ...
3 years, 10 months ago (2017-02-15 09:57:10 UTC) #7
qyearsley
On 2017/02/15 at 09:57:10, jochen wrote: > oh, the other tests are also testing the ...
3 years, 10 months ago (2017-02-17 17:12:21 UTC) #18
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-17 17:17:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693703007/110001
3 years, 10 months ago (2017-02-17 17:21:52 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 17:33:20 UTC) #25
Message was sent while issue was closed.
Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/13e532004647b3d9fefe0c3643d3...

Powered by Google App Engine
This is Rietveld 408576698