Issue 26937006: Make SkImageFilter::asNewEffect() (and all derived-class overrides) protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26937006: Make SkImageFilter::asNewEffect() (and all derived-class overrides) protected. (Closed)

Created:
7 years, 2 months ago by Stephen White

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Make SkImageFilter::asNewEffect() (and all derived-class overrides) protected. R=bsalomon@google.com, bsalomon Committed: https://code.google.com/p/skia/source/detail?r=11847

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -39 lines)			Patch
M	include/core/SkImageFilter.h	View	2 chunks	+17 lines, -17 lines	0 comments	Download
M	include/effects/SkMagnifierImageFilter.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View	4 chunks	+6 lines, -9 lines	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View	2 chunks	+11 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Stephen White

7 years, 2 months ago (2013-10-17 19:35:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r11847 (presubmit successful).