Source/web/WebPluginContainerImpl.h - Issue 26936002: Remove Widget's dependency upon its own inheritor aka ScrollView. This was nasty from an OO design…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginContainerImpl.h

Issue 26936002: Remove Widget's dependency upon its own inheritor aka ScrollView. This was nasty from an OO design… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Fix for clang compile error Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPluginContainerImpl.h

diff --git a/Source/web/WebPluginContainerImpl.h b/Source/web/WebPluginContainerImpl.h

index d8e46d698e51d19926ea26d16c24ea3e364d9c96..ccc618379d1c2716f23a27cacf1d2fe2370e8372 100644

--- a/Source/web/WebPluginContainerImpl.h

+++ b/Source/web/WebPluginContainerImpl.h

@@ -90,7 +90,7 @@ public:

virtual void handleEvent(WebCore::Event*);

virtual void frameRectsChanged();

virtual void setParentVisible(bool);

- virtual void setParent(WebCore::ScrollView*);

+ virtual void setParent(WebCore::Widget*);

virtual void widgetPositionsUpdated();

virtual void clipRectChanged() OVERRIDE;

virtual bool isPluginContainer() const { return true; }

« no previous file with comments | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »