Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: Source/web/WebPluginContainerImpl.h

Issue 26936002: Remove Widget's dependency upon its own inheritor aka ScrollView. This was nasty from an OO design… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Fix for clang compile error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 // Widget methods 83 // Widget methods
84 virtual void setFrameRect(const WebCore::IntRect&); 84 virtual void setFrameRect(const WebCore::IntRect&);
85 virtual void paint(WebCore::GraphicsContext*, const WebCore::IntRect&); 85 virtual void paint(WebCore::GraphicsContext*, const WebCore::IntRect&);
86 virtual void invalidateRect(const WebCore::IntRect&); 86 virtual void invalidateRect(const WebCore::IntRect&);
87 virtual void setFocus(bool); 87 virtual void setFocus(bool);
88 virtual void show(); 88 virtual void show();
89 virtual void hide(); 89 virtual void hide();
90 virtual void handleEvent(WebCore::Event*); 90 virtual void handleEvent(WebCore::Event*);
91 virtual void frameRectsChanged(); 91 virtual void frameRectsChanged();
92 virtual void setParentVisible(bool); 92 virtual void setParentVisible(bool);
93 virtual void setParent(WebCore::ScrollView*); 93 virtual void setParent(WebCore::Widget*);
94 virtual void widgetPositionsUpdated(); 94 virtual void widgetPositionsUpdated();
95 virtual void clipRectChanged() OVERRIDE; 95 virtual void clipRectChanged() OVERRIDE;
96 virtual bool isPluginContainer() const { return true; } 96 virtual bool isPluginContainer() const { return true; }
97 virtual void eventListenersRemoved() OVERRIDE; 97 virtual void eventListenersRemoved() OVERRIDE;
98 98
99 // WebPluginContainer methods 99 // WebPluginContainer methods
100 virtual WebElement element(); 100 virtual WebElement element();
101 virtual void invalidate(); 101 virtual void invalidate();
102 virtual void invalidateRect(const WebRect&); 102 virtual void invalidateRect(const WebRect&);
103 virtual void scrollRect(int dx, int dy, const WebRect&); 103 virtual void scrollRect(int dx, int dy, const WebRect&);
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 // WebPluginContainerImpl is the only subclass of WebPluginContainer. 212 // WebPluginContainerImpl is the only subclass of WebPluginContainer.
213 return static_cast<WebPluginContainerImpl*>(container); 213 return static_cast<WebPluginContainerImpl*>(container);
214 } 214 }
215 215
216 // This will catch anyone doing an unnecessary cast. 216 // This will catch anyone doing an unnecessary cast.
217 void toPluginContainerImpl(const WebPluginContainerImpl*); 217 void toPluginContainerImpl(const WebPluginContainerImpl*);
218 218
219 } // namespace WebKit 219 } // namespace WebKit
220 220
221 #endif 221 #endif
OLDNEW
« no previous file with comments | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698